Spoof browser time #5431
Merged
Spoof browser time #5431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…occurrence after today
…ays used the same path
…eing handled correctly, applied linter
dorner
approved these changes
Oct 26, 2025
Contributor
|
@Benjamin-Couey: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5423
Description
This PR imports the sinon.js library in order to spoof the date time the browser used during tests matches the date time Rails is currently using. This allows for JS code to be tested in specific time frames. This also means that test behavior will not depend on when the test was run, reducing flakiness.
It also fixes a bug exposed in the failing tests from the ticket. The reminder and deadline day form is updated to avoid cases where the JS library RRule calculates the next occurrence date to be today.
Type of change
How Has This Been Tested?
The existing unit tests have been updated and all pass.