[5432] Skip existing user email validation for account requests that are rejected or closed by admin #5433
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are rejected or closed by admin
dorner
approved these changes
Oct 31, 2025
Collaborator
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Technical looks fine. Needs functional review.
4 tasks
awwaiid
approved these changes
Nov 30, 2025
Collaborator
awwaiid
left a comment
awwaiid
left a comment
There was a problem hiding this comment.
Works! Verified locally by setting up an account request and then adding a duplicate user. Off of main I get an error, on this branch it lets me reject the duplicate (as desired).
awwaiid
deleted the
5432_skip_existing_user_email_validation_for_rejected_and_admin_closed_account_requests
branch
Contributor
|
@brodyf42: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5432
Description
When updating an AccountRequest record, the validation that checks for an existing user email address is skipped if the status is either
rejectedoradmin_closed. Essentially the check does not need to be performed if the request is not being accepted.Type of change
How Has This Been Tested?
Tested functionality in rails console and via the locally running application with no issues.