Fixes #2185 Follow up on dependency lib version needed#2186
Merged
ruflin merged 4 commits intoruflin:8.xfrom Jan 17, 2024
Merged
Fixes #2185 Follow up on dependency lib version needed#2186ruflin merged 4 commits intoruflin:8.xfrom
ruflin merged 4 commits intoruflin:8.xfrom
Conversation
pawelkeska
changed the title
pawelkeska
changed the title
sidz
approved these changes
Jan 17, 2024
Collaborator
sidz
left a comment
sidz
left a comment
There was a problem hiding this comment.
Brilliant. thanks @pawelkeska 👍
ruflin
reviewed
Jan 17, 2024
| return $this->getTransport(); | ||
| } | ||
|
|
||
| /** |
Owner
There was a problem hiding this comment.
This goes away because it is not supported anymore?
ruflin
approved these changes
Jan 17, 2024
Owner
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
Change LGTM. Before we merge, quickly get some details on why some parts are removed (I guess not supported anymore)
Contributor
Author
|
@ruflin yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sidz
ClientInterfacewas added from 8.4.1 i've changed composer.json@Rufin i added some tests to connection and fix bug with path in
Client