Skip to content

fix: badges property does not show icons#23

Merged
gschueler merged 2 commits intomainfrom
enh/fix-badges-values
Apr 8, 2025
Merged

fix: badges property does not show icons#23
gschueler merged 2 commits intomainfrom
enh/fix-badges-values

Conversation

@gschueler
Copy link
Copy Markdown
Member

fixes #6

@gschueler gschueler requested a review from Copilot April 8, 2025 16:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/main/java/org/rundeck/plugins/nodes/icon/IconNodeEnhancer.java:84

  • [nitpick] The empty values array in the @SelectValues annotation may seem unclear; please add a comment to explain that the actual values are set in the buildWith method.
@SelectValues(freeSelect = true, values = {})

src/main/java/org/rundeck/plugins/nodes/icon/IconNodeEnhancer.java:97

  • [nitpick] With the removal of the dynamicProperties method, ensure that tests are updated to verify that iconBadges are correctly populated via the buildWith method.
-    public Map<String, Object> dynamicProperties( final Map<String, Object> projectAndFrameworkValues, final Services services )

@gschueler gschueler merged commit 8414389 into main Apr 8, 2025
2 checks passed
@gschueler gschueler deleted the enh/fix-badges-values branch April 8, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon plugin shows blank "Badges" section

2 participants