Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Gradle wrapper scripts and properties to upgrade from an older version (3.5) to a more recent version (8.10.2), likely to address CVE scanning concerns and improve security posture.
- Updates Gradle wrapper from version 3.5 to 8.10.2
- Modernizes gradlew and gradlew.bat scripts with improved error handling and POSIX compliance
- Adds security features like distribution SHA validation and network timeout configuration
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradlew.bat | Updated Windows batch script with improved error handling, memory settings, and modernized logic |
| gradlew | Updated Unix shell script with POSIX compliance, better symlink handling, and enhanced argument processing |
| gradle/wrapper/gradle-wrapper.properties | Upgraded Gradle version to 8.10.2 and added security validation features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s | ||
| ' "$PWD" ) || exit |
There was a problem hiding this comment.
The line break in the printf statement appears to be unintentional and could cause issues. The printf format string should be on a single line or properly escaped.
| APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s | |
| ' "$PWD" ) || exit | |
| APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s\n' "$PWD" ) || exit |
jtobard
left a comment
There was a problem hiding this comment.
Although the correctly upgraded Gradle is still not used in the build (it uses Makefile), it at least has a modern version of Gradle.
No description provided.