Skip to content

Build Modernization for CVE Scanning#5

Merged
jtobard merged 1 commit intomasterfrom
build-modernization
Oct 7, 2025
Merged

Build Modernization for CVE Scanning#5
jtobard merged 1 commit intomasterfrom
build-modernization

Conversation

@fdevans
Copy link
Copy Markdown
Contributor

@fdevans fdevans commented Oct 3, 2025

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the Gradle wrapper scripts and properties to upgrade from an older version (3.5) to a more recent version (8.10.2), likely to address CVE scanning concerns and improve security posture.

  • Updates Gradle wrapper from version 3.5 to 8.10.2
  • Modernizes gradlew and gradlew.bat scripts with improved error handling and POSIX compliance
  • Adds security features like distribution SHA validation and network timeout configuration

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

File Description
gradlew.bat Updated Windows batch script with improved error handling, memory settings, and modernized logic
gradlew Updated Unix shell script with POSIX compliance, better symlink handling, and enhanced argument processing
gradle/wrapper/gradle-wrapper.properties Upgraded Gradle version to 8.10.2 and added security validation features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +89 to +90
APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s
' "$PWD" ) || exit
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line break in the printf statement appears to be unintentional and could cause issues. The printf format string should be on a single line or properly escaped.

Suggested change
APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s
' "$PWD" ) || exit
APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s\n' "$PWD" ) || exit

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@jtobard jtobard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the correctly upgraded Gradle is still not used in the build (it uses Makefile), it at least has a modern version of Gradle.

@jtobard jtobard merged commit 5454f2c into master Oct 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants