Grails 7 Migration - Rundeck 6.0 Compatibility#6
Merged
Conversation
- Update groupId to com.github.rundeck-plugins - Update version to X.Y.Z-grails7-upgrade-test - Update rundeck-core dependency to 6.0.0-SNAPSHOT - Enhanced diagnostics and error logging - Fixed test compatibility issues (JUnit 4 vs 5, Java 17) - Updated for Spring Boot 3 / Java 17
….plugins - Changed groupId: com.github.rundeck-plugins → com.rundeck.plugins - Updated Axion to 1.17.2 with prefix='' (no 'v' prefix) - Removed hardcoded version (2.0.4-grails7-upgrade-test) - Replaced external build-zip with inline pluginZip task - Added PackageCloud publishing configuration - Version now managed dynamically from git tags See: .temp/PLUGIN_TAGGING_ARCHITECTURE.md and PACKAGECLOUD_MIGRATION_PLAN.md
- Added ReplaceTokens filter to process @Version@, @author@, @url@ tokens - Added tokens map with version, date, author, url, title, description, name - Import org.apache.tools.ant.filters.ReplaceTokens This fixes the YAML parsing error where unprocessed tokens like @Version@ were being included in the published plugin.yaml file.
… config Merged master branch to get infrastructure updates: - Updated Gradle wrapper to newer version - Updated .gitignore Preserved grails7-upgrade's critical configuration: - PackageCloud groupId (com.rundeck.plugins) - Axion 1.17.2 with no prefix tagging - ZIP-as-JAR plugin structure Resolution strategy: --ours for build.gradle, --theirs for Gradle wrapper files
Upgrade Gradle wrapper to match rundeck/rundeckpro (8.14.3) for consistency. This ensures all plugins use the same build tooling version.
There was a problem hiding this comment.
Pull request overview
This PR updates the plugin’s build and packaging setup to align with newer tooling, including an updated Gradle wrapper and a revised Gradle build that produces/publishes a packaged plugin artifact.
Changes:
- Added
plugin.yamlmetadata and acontents/puppet_applyscript provider. - Updated the Gradle wrapper to Gradle 8.14.3.
- Reworked
build.gradleto build a zip-style plugin artifact via aJartask and publish it viamaven-publish.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugin.yaml | Introduces plugin/provider metadata for the Puppet Apply step. |
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper distribution URL to 8.14.3. |
| contents/puppet_apply | Adds the bash implementation executed by the script provider. |
| build.gradle | Reworks plugin packaging and publishing configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,7 +1,7 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionSha256Sum=31c55713e40233a8303827ceb42ca48a47267a0ad4bab9177123121e71524c26 | |||
There was a problem hiding this comment.
distributionUrl was bumped to Gradle 8.14.3 but distributionSha256Sum was not updated. With validateDistributionUrl=true, the wrapper will fail to download/verify because the checksum won’t match the new distribution. Update the SHA256 to the correct value for gradle-8.14.3-bin.zip (or remove the checksum if you don’t intend to validate).
Suggested change
| distributionSha256Sum=31c55713e40233a8303827ceb42ca48a47267a0ad4bab9177123121e71524c26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates this plugin for Grails 7 / Rundeck 6.0 compatibility.
Key Changes
Documentation
Migration details and handoff documentation: .github/Grails7-Handoff/
Testing
Notes
-grails7suffix (will be removed at release)