Skip to content

Conversation

@superyu1337
Copy link
Contributor

@superyu1337 superyu1337 commented Oct 6, 2025

Add HDR Dynamic Metadata splitting for both Dolby Vision RPUs and HDR10+ JSONs.

Related issue: #1005

Implementation

Adds two new parameters:

  • --dolby-vision-rpu <path>
  • --hdr10plus-json <path>

After running scene detection we load the RPU/JSON and split it.
This runs when creating the list Scenes whether that is by running scene detection or parsing an exisiting scenes.json.
It does not introduce changes to scenes.json, but adds a new field in the internally used Scene struct.

Todo

  • Sanity check on various inputs
  • Check if deserialization of scenes.json is broken
    • It could be that the deserialization is now incompatible with scenes.json files that don't include the new field.
    • No changes to scenes.json are made after 7d40165
  • Support more encoders?
    • I'm not sure about the current support for either features on the Av1an supported encoder list.
  • Make it safer
    • At the moment the the argument for the encoder just gets appended to the user provided argument list. It would be safer to replace it if it exists already.

Possible Todos

  • Implement automatic RPU conversion to Profile 8/10
  • Implement automatic extraction of dynamic metadata

This is also supposed to fix the problem of scenes.json changing. We now rebuild the metadata chunks everytime and store it only internally, no serialization to scenes.json anymore.
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 31.87500% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.20%. Comparing base (94ea800) to head (7d40165).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
av1an-core/src/scenes/mod.rs 13.72% 88 Missing ⚠️
av1an-core/src/context.rs 61.11% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
- Coverage   62.00%   61.20%   -0.80%     
==========================================
  Files          23       23              
  Lines        6416     6553     +137     
==========================================
+ Hits         3978     4011      +33     
- Misses       2438     2542     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant