Skip to content

Make OBJ_ATTR_ALL read-only. Implement write helpers. #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lokathor merged 1 commit into from
Oct 22, 2025
Merged

Make OBJ_ATTR_ALL read-only. Implement write helpers. #214

Lokathor merged 1 commit into from
Oct 22, 2025

Conversation

@undecidedapollo
Copy link
Contributor

@undecidedapollo undecidedapollo commented Oct 6, 2025

  • Addresses Inconsistent behavior writing OAM with different optimization levels #213 by making OBJ_ATTR_ALL read-only.
  • Implements a write_volatile write function on ObjAttr for explicitely writing the three halfwords to OAM.
  • Provides an extension trait + implementation for VolAddress<ObjAttr, Safe, ()> allowing for a similar API to what existed before from VolAddress<ObjAttr, Safe, Safe>

This is a breaking change.

@undecidedapollo undecidedapollo mentioned this pull request Oct 6, 2025
Open
@Lokathor
Copy link
Member

Lokathor commented Oct 18, 2025

the build failure looks like you're missing some imports.

@undecidedapollo
Copy link
Contributor Author

undecidedapollo commented Oct 18, 2025

the build failure looks like you're missing some imports.

Added the missing imports and learned something new with cargo +nightly check --no-default-features

@undecidedapollo
OBJ_ATTR_ALL / VolSeries<ObjAttr> read-only.
c89af3e 
ObjAttr write function.
Extension trait for VolAddress<ObjAttr>.
@Lokathor Lokathor merged commit 04253ad into rust-console:main Oct 22, 2025
1 check passed
@undecidedapollo undecidedapollo deleted the fix/objattrall-mmio branch October 29, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

not-yet-released semver-major

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@undecidedapollo @Lokathor