External cost recorder#170
Merged
sorpaas merged 18 commits intorust-ethereum:masterfrom Jun 21, 2023
Merged
Conversation
Contributor
Author
|
@sorpaas depends on rust-blockchain/evm-tests#24 |
sorpaas
reviewed
Jun 8, 2023
sorpaas
approved these changes
Jun 19, 2023
Member
sorpaas
left a comment
sorpaas
left a comment
There was a problem hiding this comment.
Let's remove the with-substrate feature. It's really unnecessary and I can't think of good reason why we wouldn't want to keep this enabled by default.
LGTM otherwise.
tgmichel
changed the title
with-substrate feature
sorpaas
reviewed
Jun 21, 2023
|
|
||
| /// EVM backend. | ||
| #[auto_impl::auto_impl(&, Arc, Box)] | ||
| //#[auto_impl::auto_impl(&, Arc, Box)] |
Member
There was a problem hiding this comment.
Can we still implement this for &mut and Box?
Member
There was a problem hiding this comment.
Anyway, I'm fine keeping this as is for now.
A refactoring we can do is to move record_external_operation into a separate trait Record, and then add yet another type parameter to StackExecutor R: Record. Then we can uncomment this again.
But the changes are already huge so we can do that in a separate PR.
sorpaas
approved these changes
Jun 21, 2023
Member
|
Please create a companion PR in the |
zjb0807
added a commit
to AcalaNetwork/Acala
that referenced
this pull request
Jan 22, 2024
zjb0807
added a commit
to AcalaNetwork/Acala
that referenced
this pull request
Jan 29, 2024
* update PrecompileHandle ref: rust-ethereum/evm#122 * update fee calculation ref: rust-ethereum/evm#132 * add code_size/code_hash fn in StackState trait ref: rust-ethereum/evm#140 * update evm call stack ref: rust-ethereum/evm#136 * update evm call stack ref: rust-ethereum/evm#155 * add shanghai eips 3651, 3855, 3860 ref: rust-ethereum/evm#152 * update is_precompile ref: rust-ethereum/evm#157 * fix eip-3860 ref: rust-ethereum/evm#160 * update runtime config ref: rust-ethereum/evm#161 * add eip-4399 ref: rust-ethereum/evm#162 * fix eip-2618 ref: rust-ethereum/evm#163 * fix nonce back to U256 ref: rust-ethereum/evm#166 * remove exit_substate in create functions ref: rust-ethereum/evm#168 * record external cost ref: rust-ethereum/evm#170 * add record_external_operation ref: rust-ethereum/evm#171 * add storage_growth ref: rust-ethereum/evm#173 * update evm * switch to shanghai hardfork * update ecrecover ref: polkadot-evm/frontier#964 (#2696)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes adding 3 new methods to
StackStatetrait (and 2 additional counterparts inPrecompileHandle) behind awith-substratefeature flag. This change is forced by additional resource restrictions in parachains and leaves the native gasometer logic and code totally unchanged.With this new interface implementors can have a capacity for any required metric in the
Backend. This way, prior to executing anyOpcode(inpre_validate), there is an attempt to record this new external cost(s), and much like in the case of the gasometer, it will proceed with the Opcode execution or fail (OutOfGas) if the capacity for the external metric is exhausted.As a whole, this PR is proposed in favor of alternative designs that would support this type of functionality, like for example being generic over the
Gastype in the native gasometer. Those proposals were preliminarily discarded for being too intrusive for the evm code, given this is not an standard feature and can be solved in theBackend.The methods introduced in
StackStateare:record_external_dynamic_opcode_cost: meant to be called prior to executing an Opcode (pre_validate). Calculates the amount of external resources needed for the given Opcode, and records the cost.record_external_cost: meant to be called fromrecord_external_dynamic_opcode_costimplementation and fromPrecompileHandleimplementor. Records a cost (deducts an amount from the resource pool).refund_external_cost: meant to be called fromrecord_external_dynamic_opcode_costimplementation and fromPrecompileHandleimplementor. Refunds a cost (sums an amount from the resource pool).The methods introduced in
PrecompileHandleare:record_external_cost: meant to interface withStackState.refund_external_cost: meant to interface withStackState.In addition to the feature-specific additions, in this PR there are some additional changes included that are needed to properly fail the gasometer in case any of this external resources are exhausted.