This repository was archived by the owner on Nov 21, 2018. It is now read-only.
Merged
Conversation
All it does now is runs the rust-installer scripts. Provides an uninstall option and allows component selection.
|
@brson: no appropriate reviewer found, use r? to override |
Contributor
Author
Contributor
|
r=me whenever this is ready to go, I'm trusting you on this one :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlight here is that the OS X .pkg should be better, allowing selecting of individual components or uninstallation, and supporting alternate install locations. There are tradeoffs though: the UI is weird because of the way I had to make the 'Install Rust' and 'Uninstall Rust' options checkboxes in a component select screen, with scripts that make them mutually exclusive.
The OS X .pkg just defers to rust-installer entirely, which means the OS X installer doesn't know the install size unfortunately and also doesn't provide useful error messages when something goes wrong.
I've also tested the .msi build on new EC2 images and upgraded rust-buildbot to pass
--msi.Needs to land after rust-lang/rust#22256