This repository was archived by the owner on Aug 25, 2025. It is now read-only.
Fix --without-components with subsetted components #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not entirely clear what changed in 1.66, but rust-lang/rust#105755 shows that we are failing to run the install script with --without if there are subsetted component names.
This changes the behavior of the filtering to require an exact match rather than a partial match, which seems like the better way to go. It's not very clear to me that the previous behavior was actually a good idea.
r? @jyn514 or @pietroalbini
cc rust-lang/rust#105755
Will run a try build + dev-static nightly to check this actually works, but altering the 1.66 release with these changes did seem to do the right thing. (But I think the easiest thing is to merge this first and then do that later).