std: refactor UNIX random data generation #128655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
rustbot
added
S-waiting-on-review
This PR makes a number of changes to the UNIX randomness implementation: * Use `io::Error` for centralized error handling * Move the file-fallback logic out of the `getrandom`-specific module * Stop redefining the syscalls on macOS and DragonFly, they have appeared in `libc` * Add a `OnceLock` to cache the random device file descriptor
joboet
force-pushed
the
play_with_the_dice
branch
from
b80ec51 to
207ee73
Compare
bjorn3
reviewed
Aug 5, 2024
joboet
force-pushed
the
play_with_the_dice
branch
from
51743c9 to
99c0d76
Compare
ChrisDenton
approved these changes
Aug 12, 2024
Member
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
LGTM. I've left some comments but these are just some notes to myself while I was reviewing. I do have one query but nothing that should block merging.
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of changes to the UNIX randomness implementation:
io::Errorfor centralized error handlinggetrandom-specific modulelibcOnceLockto cache the random device file descriptor