-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
btree: add {Entry,VacantEntry}::insert_entry
#133042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
This matches the recently-stabilized methods on `HashMap` entries. I've reused tracking issue rust-lang#65225 for now, but we may want to split it.
6f682b6 to
584ec95
Compare
|
r? libs-api for new unstable API surface |
|
FWIW, I'm also working on a |
|
Not 100% sure about the lifetime magic in the BTreeMap internals, but if it passes Miri then it's probably fine. @bors r+ |
Yeah, it's hairy, but it does pass Miri for me. I hope that coverage is good enough, given that I also modified |
This matches the recently-stabilized methods on
HashMapentries. I'vereused tracking issue #65225 for now, but we may want to split it.