Fix incorrect let to const suggestion for pattern bindings#152834
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Apr 22, 2026
Merged
Fix incorrect let to const suggestion for pattern bindings#152834rust-bors[bot] merged 2 commits intorust-lang:mainfrom
let to const suggestion for pattern bindings#152834rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
lapla-cogito
force-pushed
the
issue_152831
branch
from
cebca33 to
ccc0407
Compare
Kivooeo
reviewed
Feb 19, 2026
Contributor
Author
|
Friendly ping @jackh726 |
jackh726
requested changes
Apr 12, 2026
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
lapla-cogito
force-pushed
the
issue_152831
branch
from
ccc0407 to
8c83008
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lapla-cogito
force-pushed
the
issue_152831
branch
from
8c83008 to
8fd10ec
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jackh726
reviewed
Apr 21, 2026
lapla-cogito
force-pushed
the
issue_152831
branch
from
8fd10ec to
90c03d8
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
Moved tests to |
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
…uwer Rollup of 5 pull requests Successful merges: - #155546 (Improve E0308 error message for `impl Trait` return mismatches) - #152834 (Fix incorrect `let` to `const` suggestion for pattern bindings) - #155425 (Remove duplicated `Flags` methods.) - #155547 (Use per-parent disambiguators everywhere) - #155590 (Remove AttributeLintKind variants - part 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
When a variable from a pattern binding was referenced inside a
const {}block, the compiler incorrectly suggested replacingletwithconst. This was reported in #152831 forif let, but also applies towhile letandlet ... else.