Skip to content

Avoid query cycles in DataflowConstProp#155379

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
ashivaram23:mir-query-cycle
Apr 24, 2026
Merged

Avoid query cycles in DataflowConstProp#155379
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
ashivaram23:mir-query-cycle

Conversation

@ashivaram23
Copy link
Copy Markdown
Contributor

@ashivaram23 ashivaram23 commented Apr 16, 2026

Fixes #155376 by skipping coroutines.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 16, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 16, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 16, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 18 candidates

@jackh726
Copy link
Copy Markdown
Member

r? mir-opt

@rustbot rustbot assigned saethlin and unassigned jackh726 Apr 23, 2026
Comment thread tests/ui/dataflow_const_prop/recursive-async.rs Outdated
@saethlin
Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

* Avoid query cycles in DataflowConstProp
* Add -Zmir-opt-level=0 to the test
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

🔨 2 commits were squashed into 4b1f392.

@rust-bors rust-bors Bot force-pushed the mir-query-cycle branch from 431cba0 to 4b1f392 Compare April 24, 2026 03:04
@saethlin
Copy link
Copy Markdown
Member

GitHub UI had a weird message about requiring an approval after the squash. Very strange.

@ashivaram23 Thanks for the fix. I'm a bit surprised we made it this long without it!

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

📌 Commit 4b1f392 has been approved by saethlin

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 24, 2026
…thlin

Avoid query cycles in DataflowConstProp

Fixes rust-lang#155376 by skipping coroutines.
rust-bors Bot pushed a commit that referenced this pull request Apr 24, 2026
Rollup of 9 pull requests

Successful merges:

 - #155684 (Generalize IO Traits for `Arc<T>` where `&T: IoTrait`)
 - #155081 (Move and clean up some ui test)
 - #155379 (Avoid query cycles in DataflowConstProp)
 - #155663 (Eliminate `CrateMetadataRef`.)
 - #155669 (Add `Sender` diagnostic item for `std::sync::mpsc::Sender`)
 - #155698 (Syntactically reject tuple index shorthands in struct patterns to fix a correctness regression)
 - #155703 (Remove myself as a maintainer of `wasm32-wasip1-threads`)
 - #155706 (Remove `AttributeLintKind` variants - part 7)
 - #155712 (Forbid `*-pass` and `*-fail` directives in tests/crashes)
@rust-bors rust-bors Bot merged commit cdba0ce into rust-lang:main Apr 24, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 24, 2026
rust-timer added a commit that referenced this pull request Apr 24, 2026
Rollup merge of #155379 - ashivaram23:mir-query-cycle, r=saethlin

Avoid query cycles in DataflowConstProp

Fixes #155376 by skipping coroutines.
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 27, 2026
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#155684 (Generalize IO Traits for `Arc<T>` where `&T: IoTrait`)
 - rust-lang/rust#155081 (Move and clean up some ui test)
 - rust-lang/rust#155379 (Avoid query cycles in DataflowConstProp)
 - rust-lang/rust#155663 (Eliminate `CrateMetadataRef`.)
 - rust-lang/rust#155669 (Add `Sender` diagnostic item for `std::sync::mpsc::Sender`)
 - rust-lang/rust#155698 (Syntactically reject tuple index shorthands in struct patterns to fix a correctness regression)
 - rust-lang/rust#155703 (Remove myself as a maintainer of `wasm32-wasip1-threads`)
 - rust-lang/rust#155706 (Remove `AttributeLintKind` variants - part 7)
 - rust-lang/rust#155712 (Forbid `*-pass` and `*-fail` directives in tests/crashes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-Zmir-opt-level >= 3 errors with recursive async

4 participants