Some metadata cleanups#155632
Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom Apr 22, 2026
Merged
Conversation
`Metadata` has two methods, `blob` and `decoder`, which are not used together. Splitting the trait in two will allow some cleanups in subsequent commits.
It's currently an impl for `(CrateMetadataRef, TyCtxt)`, but (a) the `TyCtxt` is not used, and (b) the `CrateMetadataRef` can be simplified to a `CrateMetadata` because `CStore` access isn't required. This require changing `blob` to take `&self`, which is no big deal, and it simplifies many `get` calls.
They are unused because of the previous commit.
rustbot
added
S-waiting-on-review
Contributor
Author
|
I don't think this will affect perf, but let's make sure: @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
rustbot
added
S-waiting-on-author
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (9f48501): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 491.717s -> 508.836s (3.48%) |
rustbot
removed
the
S-waiting-on-perf
nnethercote
force-pushed
the
split-Metadata
branch
from
be48911 to
f0ebd66
Compare
rustbot
added
S-waiting-on-review
Contributor
Author
|
@rustbot ready |
mejrs
reviewed
Apr 22, 2026
Contributor
There was a problem hiding this comment.
I'm not a fan of having these kind of impls for tuples, thanks for cleaning that up a bit.
@bors r+
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
Regarding unused |
Contributor
Author
This PR removes some of those, but not all of them. |
Contributor
|
@bors rollup |
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 22, 2026
…uwer Rollup of 10 pull requests Successful merges: - #154794 (Add on_unmatch_args) - #155133 (Document precision considerations of `Duration`-float methods) - #154283 (Remove `nodes_in_current_session` field and related assertions) - #155374 (rustdoc: fix a few spots where emit isn't respected) - #155587 (Immediately feed visibility on DefId creation) - #155622 (c-variadic: `va_arg` fixes ) - #155629 (rustc_public: Add `constness` & `asyncness` in `FnDef`) - #155632 (Some metadata cleanups) - #155639 (BinOpAssign always returns unit) - #155647 (rustc-dev-guide subtree update)
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 24, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#154794 (Add on_unmatch_args) - rust-lang/rust#155133 (Document precision considerations of `Duration`-float methods) - rust-lang/rust#154283 (Remove `nodes_in_current_session` field and related assertions) - rust-lang/rust#155374 (rustdoc: fix a few spots where emit isn't respected) - rust-lang/rust#155587 (Immediately feed visibility on DefId creation) - rust-lang/rust#155622 (c-variadic: `va_arg` fixes ) - rust-lang/rust#155629 (rustc_public: Add `constness` & `asyncness` in `FnDef`) - rust-lang/rust#155632 (Some metadata cleanups) - rust-lang/rust#155639 (BinOpAssign always returns unit) - rust-lang/rust#155647 (rustc-dev-guide subtree update)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in individual commits.
r? @mejrs