Skip to content

Update LLVM to 22.1.4#155645

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
dianqk:update-llvm
Apr 24, 2026
Merged

Update LLVM to 22.1.4#155645
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
dianqk:update-llvm

Conversation

@dianqk
Copy link
Copy Markdown
Member

@dianqk dianqk commented Apr 22, 2026

View all comments

Unlocks #155249.

I made a new branch that removes CI checks for macOS and reverts rust-lang/llvm-project@24b53fb.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @cuviper

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

⚠️ Warning ⚠️

@dianqk
Copy link
Copy Markdown
Member Author

dianqk commented Apr 22, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 22, 2026
rust-bors Bot pushed a commit that referenced this pull request Apr 22, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 22, 2026

☀️ Try build successful (CI)
Build commit: ed52240 (ed522401422b2636b311e93d2e0a605b7deb0283, parent: cf1817bc6ecd2d14ca492247c804bad31948dd56)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (ed52240): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) - - 0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 491.458s -> 492.344s (0.18%)
Artifact size: 394.40 MiB -> 394.40 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 22, 2026
@nikic
Copy link
Copy Markdown
Contributor

nikic commented Apr 22, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 22, 2026

📌 Commit a21eee0 has been approved by nikic

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Apr 23, 2026
Update LLVM to 22.1.4

Unlocks #155249.

I made a new branch that removes CI checks for macOS and reverts rust-lang/llvm-project@24b53fb.
@rust-log-analyzer

This comment has been minimized.

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 23, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 23, 2026

💔 Test for 328de08 failed: CI. Failed job:

@nikic
Copy link
Copy Markdown
Contributor

nikic commented Apr 23, 2026

It looks like some tail call support for LoongArch was reverted in llvm/llvm-project#191525. So we should apply #155259 to LLVM 22 as well.

Tail call support for LoongArch was reverted in LLVM 22 also.
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2026
@rustbot rustbot added the F-explicit_tail_calls `#![feature(explicit_tail_calls)]` label Apr 23, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 23, 2026
//@[loongarch32] compile-flags: --target loongarch32-unknown-none
//@[loongarch32] needs-llvm-components: loongarch
//@[loongarch32] ignore-llvm-version: 23
//@[loongarch32] ignore-llvm-version: 22 - 23
Copy link
Copy Markdown
Member

@cuviper cuviper Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have context -- is this expected to come back in 24? If not (or that's unknown) shouldn't we use max-llvm-major-version: 21 for these?

View changes since the review

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to llvm/llvm-project#191525 (review), I assume this will come back in 23 or 24. I think ignore-llvm-version: 22 - 23 makes easier to tell whether this is fixed in 24 and we can just remove these tests if they fails on 24.

@nikic
Copy link
Copy Markdown
Contributor

nikic commented Apr 24, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

📌 Commit 250beb3 has been approved by nikic

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 24, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

☀️ Test successful - CI
Approved by: nikic
Duration: 3h 16m 7s
Pushing acb65f3 to main...

@rust-bors rust-bors Bot merged commit acb65f3 into rust-lang:main Apr 24, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ec6f9a5 (parent) -> acb65f3 (this PR)

Test differences

Show 38 test diffs

Stage 1

  • [ui] tests/ui/explicit-tail-calls/support/bystack.rs#loongarch32: pass -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J1)
  • [ui] tests/ui/explicit-tail-calls/support/bystack.rs#loongarch64: pass -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J1)
  • [ui] tests/ui/explicit-tail-calls/support/byval.rs#loongarch32: pass -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J1)
  • [ui] tests/ui/explicit-tail-calls/support/byval.rs#loongarch64: pass -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J1)
  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J2)
  • [codegen] tests/codegen-llvm/issues/issue-122600-ptr-discriminant-update.rs#old: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J2)
  • [codegen] tests/codegen-llvm/issues/issue-37945.rs#new: ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) -> ignore (ignored when the LLVM version 22.1.4 is older than 23.0.0) (J2)
  • [codegen] tests/codegen-llvm/issues/matches-logical-or-141497.rs: ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) -> ignore (ignored when the LLVM version 22.1.4 is older than 23.0.0) (J2)
  • [codegen] tests/codegen-llvm/scalable-vectors/debuginfo.rs#PRE-LLVM-22: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J2)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-gather.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J2)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-masked-load.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J2)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-masked-store.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J2)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-scatter.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J2)
  • [codegen] tests/codegen-llvm/vec_pop_push_noop.rs#old: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J2)
  • [codegen] tests/codegen-llvm/vecdeque_pop_push.rs#old: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J2)

Stage 2

  • [codegen] tests/codegen-llvm/amdgpu-addrspacecast.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J0)
  • [codegen] tests/codegen-llvm/issues/issue-122600-ptr-discriminant-update.rs#old: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J0)
  • [codegen] tests/codegen-llvm/issues/issue-37945.rs#new: ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) -> ignore (ignored when the LLVM version 22.1.4 is older than 23.0.0) (J0)
  • [codegen] tests/codegen-llvm/issues/matches-logical-or-141497.rs: ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) -> ignore (ignored when the LLVM version 22.1.4 is older than 23.0.0) (J0)
  • [codegen] tests/codegen-llvm/scalable-vectors/debuginfo.rs#PRE-LLVM-22: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J0)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-gather.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J0)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-masked-load.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J0)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-masked-store.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J0)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-scatter.rs#LLVM21: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J0)
  • [codegen] tests/codegen-llvm/vec_pop_push_noop.rs#old: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J0)
  • [codegen] tests/codegen-llvm/vecdeque_pop_push.rs#old: ignore (ignored when the LLVM version (22.1.2) is newer than majorversion 21) -> ignore (ignored when the LLVM version (22.1.4) is newer than majorversion 21) (J0)
  • [ui] tests/ui/explicit-tail-calls/support/bystack.rs#loongarch32: ignore (gcc backend is marked as ignore) -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J3)
  • [ui] tests/ui/explicit-tail-calls/support/bystack.rs#loongarch64: ignore (gcc backend is marked as ignore) -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J3)
  • [ui] tests/ui/explicit-tail-calls/support/byval.rs#loongarch32: ignore (gcc backend is marked as ignore) -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J3)
  • [ui] tests/ui/explicit-tail-calls/support/byval.rs#loongarch64: ignore (gcc backend is marked as ignore) -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J3)
  • [ui] tests/ui/explicit-tail-calls/support/bystack.rs#loongarch32: pass -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J4)
  • [ui] tests/ui/explicit-tail-calls/support/bystack.rs#loongarch64: pass -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J4)
  • [ui] tests/ui/explicit-tail-calls/support/byval.rs#loongarch32: pass -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J4)
  • [ui] tests/ui/explicit-tail-calls/support/byval.rs#loongarch64: pass -> ignore (ignored when the LLVM version is between 22.0.0 and 23.0.0) (J4)
  • [codegen] tests/codegen-llvm/array-equality.rs#llvm-next: ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) -> ignore (ignored when the LLVM version 22.1.4 is older than 23.0.0) (J5)
  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) (J6)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard acb65f36a0697070a7083c8733f49e7efdbaff61 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 42m 35s -> 1h 3m (+50.2%)
  2. x86_64-gnu-nopt: 1h 51m -> 2h 43m (+47.0%)
  3. dist-aarch64-linux: 1h 45m -> 2h 34m (+46.0%)
  4. x86_64-gnu-tools: 53m 26s -> 1h 14m (+39.1%)
  5. pr-check-1: 28m 13s -> 38m 51s (+37.7%)
  6. pr-check-2: 39m 14s -> 51m 29s (+31.2%)
  7. x86_64-gnu-gcc: 1h 3m -> 1h 22m (+29.5%)
  8. x86_64-gnu-debug: 1h 32m -> 1h 56m (+25.9%)
  9. i686-msvc-2: 2h 17m -> 1h 42m (-25.1%)
  10. arm-android: 1h 38m -> 2h (+22.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (acb65f3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.9%, secondary 5.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.9% [2.9%, 2.9%] 1
Regressions ❌
(secondary)
8.2% [7.4%, 8.7%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.1%, -1.1%] 1
All ❌✅ (primary) 2.9% [2.9%, 2.9%] 1

Cycles

Results (secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.1%, 3.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.5% [-6.5%, -6.5%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.1%, -0.0%] 33
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.0%] 22
All ❌✅ (primary) -0.1% [-0.1%, -0.0%] 33

Bootstrap: 492.674s -> 491.731s (-0.19%)
Artifact size: 394.26 MiB -> 394.21 MiB (-0.01%)

@dianqk dianqk deleted the update-llvm branch April 24, 2026 21:48
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 28, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 28, 2026
rust-timer added a commit that referenced this pull request Apr 28, 2026
Rollup merge of #155905 - dianqk:update-llvm, r=nikic

Update LLVM to 22.1.4 (again)

#155756 undoes #155645.

cc @weihanglo

r? @nikic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-explicit_tail_calls `#![feature(explicit_tail_calls)]` merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants