Update LLVM to 22.1.4#155645
Conversation
|
r? @cuviper rustbot has assigned @cuviper. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (ed52240): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 491.458s -> 492.344s (0.18%) |
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
Update LLVM to 22.1.4 Unlocks #155249. I made a new branch that removes CI checks for macOS and reverts rust-lang/llvm-project@24b53fb.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 328de08 failed: CI. Failed job:
|
|
It looks like some tail call support for LoongArch was reverted in llvm/llvm-project#191525. So we should apply #155259 to LLVM 22 as well. |
Tail call support for LoongArch was reverted in LLVM 22 also.
| //@[loongarch32] compile-flags: --target loongarch32-unknown-none | ||
| //@[loongarch32] needs-llvm-components: loongarch | ||
| //@[loongarch32] ignore-llvm-version: 23 | ||
| //@[loongarch32] ignore-llvm-version: 22 - 23 |
There was a problem hiding this comment.
I don't have context -- is this expected to come back in 24? If not (or that's unknown) shouldn't we use max-llvm-major-version: 21 for these?
There was a problem hiding this comment.
According to llvm/llvm-project#191525 (review), I assume this will come back in 23 or 24. I think ignore-llvm-version: 22 - 23 makes easier to tell whether this is fixed in 24 and we can just remove these tests if they fails on 24.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing ec6f9a5 (parent) -> acb65f3 (this PR) Test differencesShow 38 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard acb65f36a0697070a7083c8733f49e7efdbaff61 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (acb65f3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 2.9%, secondary 5.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 492.674s -> 491.731s (-0.19%) |
Update LLVM to 22.1.4 (again) rust-lang#155756 undoes rust-lang#155645. cc @weihanglo r? @nikic
Update LLVM to 22.1.4 (again) rust-lang#155756 undoes rust-lang#155645. cc @weihanglo r? @nikic
Rollup merge of #155905 - dianqk:update-llvm, r=nikic Update LLVM to 22.1.4 (again) #155756 undoes #155645. cc @weihanglo r? @nikic
View all comments
Unlocks #155249.
I made a new branch that removes CI checks for macOS and reverts rust-lang/llvm-project@24b53fb.