test: Add a regression test for Apple platforms aborting on `free` by tgross35 · Pull Request #155713 · rust-lang/rust

tgross35 · 2026-04-24T02:16:24Z

Add a regression test for #150898 to make users aware that if this test failures, they may encounter unusual behavior elsewhere.

rustbot · 2026-04-24T02:16:38Z

r? @adwinwhite

rustbot has assigned @adwinwhite.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 19 candidates

tgross35 · 2026-04-24T02:16:45Z

@bors try jobs=aarch64-apple

test: Add a regression test for Apple platforms aborting on `free` try-job: aarch64-apple

rust-bors · 2026-04-24T02:25:45Z

💔 Test for eb1af91 failed: CI. Failed job:

try - aarch64-apple (web logs, enhanced plaintext logs)

tgross35 · 2026-04-24T02:28:16Z

Blocked of course if the runner in CI fails.

@dianqk this is just your repro from #150898 (comment).

test: Add a regression test for Apple platforms aborting on `free` try-job: aarch64-apple

dianqk · 2026-04-24T05:40:47Z

+// bug. If this fails with SIGABRT, you may need to upgrade your system to
+// avoid other unexpected behavior.
+//
+// The bug was resolved by MacOS 26.4.


Suggested change

// The bug was resolved by MacOS 26.4.

// The bug was resolved by macOS 26.4.

View changes since the review

dianqk · 2026-04-24T05:47:15Z

+#[unsafe(no_mangle)]
+fn retv() -> Reproducer {
+    // let x = [48, 0, 3, 1, 48, 0];
+    let x = [0, 0, 3, 0, 0, 0];


I don't know if this can pass Miri check. Should we use let x = [48, 0, 3, 1, 48, 0];?

View changes since the review

I replaced the test case with something that I think should be less reliant on codegen, based on your asm repro. I found that using threads makes it reproduce is every time, or at least hasn't not crashed in the
30-40 times I've run it.

dianqk · 2026-04-24T05:51:26Z

+
+        let s = 128;
+        // A few more allocations seem to be necessary, probably to prime
+        // the allocator find the bug.


Should we document that this test can be a flaky test?

View changes since the review

Mentioned this in the comment that it can have false negatives but is also pretty reliable

test: Add a regression test for Apple platforms aborting on `free` try-job: aarch64-apple

Add a regression test for RUST-150898 to make users aware that if this test fails, they may encounter unusual behavior elsewhere. Original repro authored by dianqk.

tgross35 · 2026-04-24T09:39:12Z

@bors try jobs=aarch64-apple

r? @dianqk

test: Add a regression test for Apple platforms aborting on `free` try-job: aarch64-apple

tgross35 · 2026-04-24T09:43:14Z

Any idea what the actual failure mechanism is in the buggy allocator? I can't wrap my head around how writing a random value to a (should be) valid allocation could cause free to not work.

rust-bors · 2026-04-24T12:43:48Z

☀️ Try build successful (CI)
Build commit: fa6c504 (fa6c504d6bea64e370fd51fe3a340feeec21811e, parent: d493b7c5ac637ed7edf626128b9f14796a2dad20)

dianqk · 2026-04-24T13:20:26Z

Any idea what the actual failure mechanism is in the buggy allocator? I can't wrap my head around how writing a random value to a (should be) valid allocation could cause free to not work.

I have no idea. Really. And I don't think Apple will share this bug.

dianqk · 2026-04-24T13:20:36Z

@bors r+ rollup

rust-bors · 2026-04-24T13:20:40Z

📌 Commit 150905c has been approved by dianqk

It is now in the queue for this repository.

…=dianqk test: Add a regression test for Apple platforms aborting on `free` Add a regression test for rust-lang#150898 to make users aware that if this test failures, they may encounter unusual behavior elsewhere.

…uwer Rollup of 12 pull requests Successful merges: - #149452 (Refactor out common code into a `IndexItem::new` constructor) - #155621 (Document #[diagnostic::on_move] in the unstable book.) - #155635 (delegation: rename `Self` generic param to `This` in recursive delegations) - #155730 (Some cleanups around per parent disambiguators) - #153537 (rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu) - #155219 (Do not suggest borrowing enclosing calls for nested where-clause obligations) - #155408 (rustdoc: Fix Managarm C Library name in cfg pretty printer) - #155571 (Enable AddressSanitizer on arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf) - #155713 (test: Add a regression test for Apple platforms aborting on `free`) - #155723 (Fix tier level for 5 thumb bare-metal ARM targets) - #155735 (Fix typo by removing extra 'to') - #155736 (Remove `AllVariants` workaround for rust-analyzer)

Rollup merge of #155713 - tgross35:150898-regression-test, r=dianqk test: Add a regression test for Apple platforms aborting on `free` Add a regression test for #150898 to make users aware that if this test failures, they may encounter unusual behavior elsewhere.

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 24, 2026

tgross35 marked this pull request as ready for review April 24, 2026 02:16

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2026

rustbot assigned adwinwhite Apr 24, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 24, 2026