Closed
Conversation
Contributor
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
The issue with the snapshots is that in stage0 there are lots of warnings emitted. There may also be an issue where copiletest fails to build. The way to solve these is by having the crates properly declare that they are using unstable features. Once they do that the makefiles will no longer need to do the bootstrap hack for -dev, -nightly or -snapshot builds. This fix is done in my followup feature staging PR, but since that will take some days to land I will prepare another such patch to help get this snapshot landed. |
Merged
bors
added a commit
that referenced
this pull request
Jan 18, 2015
This fixes the issues mentioned in #21236, as well as the one #21230 where `CFG_BOOTSTRAP_KEY` was being set to simply 'N'. It changes the build such that `RUSTC_BOOTSTRAP_KEY` is only exported on -beta and -stable, so that the behavior of the -dev, -nightly, and snapshot compilers is the same everywhere. Haven't run it completely through 'make check' yet, but the I have verified that the aforementioned issues are fixed. r? @alexcrichton cc @eddyb
bors
added a commit
that referenced
this pull request
Jan 18, 2015
This fixes the issues mentioned in #21236, as well as the one #21230 where `CFG_BOOTSTRAP_KEY` was being set to simply 'N'. It changes the build such that `RUSTC_BOOTSTRAP_KEY` is only exported on -beta and -stable, so that the behavior of the -dev, -nightly, and snapshot compilers is the same everywhere. Haven't run it completely through 'make check' yet, but the I have verified that the aforementioned issues are fixed. r? @alexcrichton cc @eddyb
spikespaz
pushed a commit
to spikespaz/dotwalk-rs
that referenced
this pull request
Aug 29, 2024
This fixes the issues mentioned in rust-lang/rust#21236, as well as the one rust-lang/rust#21230 where `CFG_BOOTSTRAP_KEY` was being set to simply 'N'. It changes the build such that `RUSTC_BOOTSTRAP_KEY` is only exported on -beta and -stable, so that the behavior of the -dev, -nightly, and snapshot compilers is the same everywhere. Haven't run it completely through 'make check' yet, but the I have verified that the aforementioned issues are fixed. r? @alexcrichton cc @eddyb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cannot be merged as-is because of #21230, but I wanted to have the cleanup work here for when we get a clean shapshot.
Fwiw, the hack works on all platforms but Windows, which has some weird byte values around the actual strings, and
sed s/.*//doesn't match them (or maybe it breaks on non-unicode?).r? @alexcrichton