Update std::error example#23836
Conversation
To not use `old_io` and `os`, which are deprecated. Since there is no more `MemoryMap` used byte parsing instead to generate the second potential error.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Whoops... Trailing whitespace. My bad. I'll fix this in a few minutes. |
|
The build got an error on |
|
I'm personally not a fan of things being compressed to one line |
|
Formatting was done by the |
src/libcore/error.rs
Outdated
There was a problem hiding this comment.
This should be over four lines
|
r=me after the nit, thank you! (the playpen formatter is not perfect) |
|
@bors: r=steveklabnik rollup |
|
📌 Commit d4b5f65 has been approved by |
To not use `old_io` and `os`, which are deprecated. Since there is no more `MemoryMap` used byte parsing instead to generate the second potential error. You can see the code working fine [here](http://is.gd/4g0wwp) on the PlayPen.
7 participants
To not use
old_ioandos, which are deprecated. Since there is no moreMemoryMapused byte parsing instead to generate the second potential error.You can see the code working fine here on the PlayPen.