Add test for "malformed macro lhs" and change back span_bug to span_fatal#30708
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 5, 2016
Merged
Add test for "malformed macro lhs" and change back span_bug to span_fatal#30708bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
force-pushed
the
malformed_macro
branch
from
f1b469a to
6e68cdf
Compare
Contributor
|
The intention in #29828 was that macro validity is checked in Alas, it seems I missed some cases and caused regression. I think this is a good fix in the meantime. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 6e68cdf has been approved by |
Collaborator
|
⌛ Testing commit 6e68cdf with merge dbacacd... |
bors
added a commit
that referenced
this pull request
Jan 5, 2016
Collaborator
brson
added
the
beta-nominated
Contributor
|
Backport to fix #30669 |
nikomatsakis
added
the
beta-accepted
alexcrichton
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #30669