Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/libstd/io/mod.rs
Outdated
| impl<T: BufRead, U: BufRead> BufRead for Chain<T, U> { | ||
| fn fill_buf(&mut self) -> Result<&[u8]> { | ||
| if !self.done_first { | ||
| match try!(self.first.fill_buf()) { |
There was a problem hiding this comment.
As I mentioned in #32536, you should probably use the ? operator here.
|
Thanks! Could you add some tests here as well? |
|
@alexcrichton Where should I put the tests? |
|
Either |
|
Looks good to me, but deferring the r to @alexcrichton (github unfortunately doesn't notify reviewers when new commits are pushed to a PR, so you may want to ping the comments after making changes, BTW) |
Implement BufRead for Chain Addresses #32536
|
Yay! 😃 |
7 participants
Addresses #32536