Ensure valid TraitRefs are created for GATs #82066
Conversation
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Also make sure that type arguments of associated types are printed in some error messages.
matthewjasper
force-pushed
the
trait-ref-fix
branch
from
73cd992 to
eeb82e4
Compare
|
Hmm, I actually have a much more minimal variation of this done: jackh726@7caf640 Looking through this, there seems to be a lot more here. Need to look through and see how it's different. |
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
Just one concern re. lang item but otherwise LGTM
|
@bors r+ |
|
📌 Commit eeb82e4 has been approved by |
bors
added
S-waiting-on-bors
| @@ -0,0 +1,17 @@ | |||
| // Test that correct syntax is used in suggestion to constrain associated type | |||
|
|
|||
| #![feature(generic_associated_types)] | |||
There was a problem hiding this comment.
Out of curiosity, why not #![allow(incomplete_features)] in these? It's still one line and clears up the .stderr view.
There was a problem hiding this comment.
imo, #![allow(incomplete_features)] could be missed later on when this is no longer an incomplete feature and it could be removed. So, personally, I prefer to just have the warning in the stderr files now and have it removed later.
8 participants
This fixes
ProjectionTy::trait_refto use the correct substs. Places that need all of the substs have been updated to not usetrait_ref.r? @jackh726