Integrate Clippy into the project#1724
Conversation
d6268ad to
f7fecde
Compare
Kobzol
left a comment
There was a problem hiding this comment.
Hi, thanks for the PR! I left some comments. I wonder what was your motivation for this PR? Do you work on Clippy and want to measure its performance on crates?
collector/compile-benchmarks/cargo-0.60.0/src/cargo/core/profiles.rs
Outdated
Show resolved
Hide resolved
Yep, we wanted a tool for measuring Clippy's performance on crates. Not for every commit, but to run once every 7 days or when triggered by a maintainer (We don't need a lot of active monitoring + Clippy benchmarking is really resource-intensive) |
9f76490 to
19bb97f
Compare
|
This new commit should be just like the first one, but discarding anything server-related =^w^= |
Kobzol
left a comment
There was a problem hiding this comment.
Thanks for the changes. Some problems that cause CI to fail still have to be resolved, as per the other comments.
Also, as per #1724 (comment), we shouldn't include Clippy in Profile::all() for now. Let's just remove it from there, that should fix collection on the server. Later we might add it back once we're sure that clippy benchmarks can be run on the perf server.
Kobzol
left a comment
There was a problem hiding this comment.
Great, thanks for the changes! :)
This PR integrates Clippy into the project.
A user can run the
clippyprofile with a local Clippy build, with the--clippyflag targetting to the Clippy executable:But I'm having some problems with the bot integration, so some feedback and tips in those files would be very appreciated.
Thanks for the feedback ❤️