Invalid formating for conditional compilation rule

[r8d8]

Formatter v0.8.6 prodices invalid outup for multiargument conditional compilation rule
Resulting code doesn't compile

Expected:

/// Default path (*nix) #[cfg(all(unix, not(target_os = "macos") , not(target_os = "ios"), not(target_os = "android")))]

Received:

/// Default path (*nix) #[cfg(all(unix, not(target_os = "macos") ), not(target_os = "ios") ), not(target_os = "android")))]

[Lakier15]

I have got similar problems. Rustfmt is doing something weird with #[cfg()] and #[cfg_attr()].

Example with #[cfg()]:

#[cfg(target_os = "freertos")] 
match port_id { 
    'a' | 'A' => GpioPort { port_address: GPIO_A }, 
    'b' | 'B' => GpioPort { port_address: GPIO_B }, 
    _ => panic!(),
}

becomes

#[cfg(target_os = "freertos")]    #[cfg(target_os = "freertos")] 
    #[cfg(target_os = "freertos")] match port_id { 
         'a' | 'A' => GpioPort { port_address: GPIO_A }, 
         'b' | 'B' => GpioPort { port_address: GPIO_B }, 
         _ => panic!(),
    }

Example with #[cfg_attr()]:

#[cfg_attr(not(target_os = "freertos"), allow(unused_variables))]

becomes

#[cfg_attr(not(target_os = "freertos") /* ) /* ) */, allow(unused_variables))]

[topecongiro]

Thanks for raising this issue. Looks like the span from ast::MetaItem and ast::NestedMetaItem does not contain the closing paren and rustfmt inserts it for recovery.

[mjfeller]

Similar problems from me as well.

#[cfg(all(not(test), target_os = "macos"))]

becomes

#[cfg(all(not(test) ), target_os = "macos"))]

[topecongiro]

@mjfeller Thanks, this is fixed via #1669.