Format error and typeof types#4416
Merged
topecongiro merged 2 commits intorust-lang:masterfrom Sep 9, 2020
Merged
Conversation
calebcartwright
pushed a commit
to calebcartwright/rustfmt
that referenced
this pull request
Dec 19, 2020
* Add a test for rust-lang#4357 * Format error and typeof types
calebcartwright
pushed a commit
that referenced
this pull request
Dec 20, 2020
* Add a test for #4357 * Format error and typeof types
Contributor
|
Backport done in #4605 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two cases are simple enough; I might as well support it instead of panicking.
Also, in a bit extreme case the current implementation can panic against valid Rust code when macro is involved:
Close #4357.