Fix import_granularity option when the use tree has an alias#5209
Merged
calebcartwright merged 2 commits intomasterfrom Feb 4, 2022
Merged
Fix import_granularity option when the use tree has an alias#5209calebcartwright merged 2 commits intomasterfrom
calebcartwright merged 2 commits intomasterfrom
Conversation
Member
There was a problem hiding this comment.
Code lgtm, though would you mind adding tests that have the One and Crate variants too? Refs #5166
Contributor
Author
|
Thanks for the review, I've added tests in my latest commit. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #5131