Move test kernels to a separate workspace #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test kernels need to be built for a different target and we don't want to unify dependency features with the main packages (as this can lead to enabled `std` features).
phil-opp
force-pushed
the
separate-workspace-for-test-kernels
branch
from
f483365 to
80e1905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test kernels need to be built for a different target and we don't want to unify dependency features with the main packages (as this can lead to enabled
stdfeatures).The test kernels are still built as part of the main
bootloaderpackage because they are specified as artifact dependencies. For completeness, this PR also adds new check/fmt/clippy steps for the new workspace. We also set a default target for thetests/test_kernelsdir.This PR should resolve the issues we saw in #485.