-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Queston about one event struct #1627
Copy link
Copy link
Closed
Labels
F - duplicateThis issue or pull request already existsThis issue or pull request already exists
Description
I've been looking through docs for WindowEvent and found the following definiton:
ScaleFactorChanged {
scale_factor: f64,
new_inner_size: &'a mut PhysicalSize<u32>,
},I have several questions
- Why is
new_inner_sizea mutable reference? That seems really weird - Why is it a reference at all? Why not just make it a value?
If there are no reasons, I'd like to make a PR to fix that... After all it will potentially make WindowEvent 'static + Clone + Copy. Not only that. It seems like the whole Event struct will become Clone + 'static. Maybe even Copy!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
F - duplicateThis issue or pull request already existsThis issue or pull request already exists