Ctrl sometimes gets "stuck" on X11

[fredizzimo]

This was reported in

neovide/neovide#2228

The neovide_rCURRENT.log is huge, by contains all key presses reported by Winit, and the modifier states. Search for KeyEvent and ModifiersState or filter by [neovide::window::keyboard_manager]

The key up event is received, but the modifier state is not updated. The modifiers are reported strange in other ways as well, for example shortly after, when super is pressed it alternates between super and no modifiers state.

I suspect this is some kind of timing issue, since it only happens on certain file types, and Neovide does not have any file type specific handling.

[kchibisov]

We pass modifiers from the xkb event. So there's either event or no event, but could be logic to send modifier lazily not work.

[fredizzimo]

@kchibisov, we just got a report of a very similar issue, but it was reported to happen on Wayland as well and we don't have any logs yet, so it might be a different but similar issue.

• On occasion, I must press control characters twice before Neovide recognizes them. neovide/neovide#2358

But is it possible that this could affect Wayland too?

[kchibisov]

No, wayland having thing like that is not our bug.

[kchibisov]

You can also provide a WAYLAND_DEBUG=1 log along side with the log showing modifiers(from winit), but we straight apply the state from the wayland compositor and just forget it, if it's desynced it means that modifiers were not updated by compositor correctly.

where with x11 it's just x11 can't put its shit together and use all events to deliver that control state, which I already fixed here #3486 .

[fredizzimo]

Thank you, I asked for that information as well. I will open a new issue if I can determine that it's a winit issue, and otherwise just resolve the issue in Neovide.