Conversation
cpu
approved these changes
Feb 10, 2026
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
Not super happy about the MSRV bump here, but given that we also ship a CLI crate, this seems like the prudent thing to do maybe?
It feels reasonable to me but I don't feel strongly if someone else does. Based on my math 1.88 just fits under our documented MSRV policy. I suspect this dep's decision is pushing lots of crates to adjust MSRV and we might as well ride the wave 🤷♂️
Member
|
@est31 are you interested/available to review this? |
est31
approved these changes
Feb 19, 2026
Member
est31
left a comment
est31
left a comment
There was a problem hiding this comment.
1.88 is within the MSRV policy so why not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, the time update for https://rustsec.org/advisories/RUSTSEC-2026-0009.html.
Not super happy about the MSRV bump here, but given that we also ship a CLI crate, this seems like the prudent thing to do maybe?