server: allow splitting and reassembling a StartHandshake#127
Merged
djc merged 1 commit intorustls:mainfrom Sep 17, 2025
Merged
server: allow splitting and reassembling a StartHandshake#127djc merged 1 commit intorustls:mainfrom
StartHandshake#127djc merged 1 commit intorustls:mainfrom
Conversation
This adds two methods to the existing `StartHandshake` in order to allow splitting and reconstructing the underlying components.
djc
approved these changes
Sep 16, 2025
ctz
approved these changes
Sep 16, 2025
Member
ctz
left a comment
There was a problem hiding this comment.
I guess the other option would be to make these fields public -- this API also commits us to never adding new fields that need non-trivial values (and I think this is OK for this struct).
Member
I'll follow up on that. |
Contributor
Author
Indeed. Two options I considered (and discarded) before opening this PR:
|
This was referenced Sep 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two methods to the existing
StartHandshakein order to allow splitting and reconstructing the underlying components.For context and usecase, see #125.