Only prevent user creation on colon characters, separate out tests#1
Merged
rutuja-amazon merged 1 commit intorutuja-amazon:username-validationfrom Dec 9, 2022
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
1 task
shikharj05
reviewed
Dec 6, 2022
|
|
||
| public class InternalUsersApiAction extends PatchableResourceApiAction { | ||
| static final List<String> RESTRICTED_FROM_USERNAME = ImmutableList.of( | ||
| ":" // Not allowed in basic auth, see https://stackoverflow.com/a/33391003/533057 |
There was a problem hiding this comment.
While restricting to : is good, we should allowlist known safe characters that can be used. Performing stricter input validation will help improve security posture against known injection, path traversal, etc. attacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only prevent user creation on colon characters, separate out tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.