Upgrade jsdom to v28 and fix CSS selector scoping for spec compliance#198
Merged
Upgrade jsdom to v28 and fix CSS selector scoping for spec compliance#198
Conversation
- Update jsdom ^19.0.0 → ^28.1.0 and @types/jsdom ^16.2.14 → ^21.1.7 to resolve GHSA-vpq2-c234-7xj6 (via http-proxy-agent/@tootallnate/once) - Fix roster parsers that relied on jsdom 19's non-spec-compliant behavior where element.querySelectorAll("tagname>child") incorrectly matched the context element itself against the leading tagname. jsdom 28 is now spec-compliant and only searches descendants. Changed all ParseSelections/ParseUnits calls from: root.querySelectorAll("force>selections>selection") to the spec-compliant equivalent using :scope or nested-force selectors. roster40k.ts uses a combined selector to also capture nested detachment forces (multi-detachment rosters embed a second force inside the first). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Project was migrated to Vite. Remove leftover webpack.config.js, webpack.config.prod.js, .github/workflows/webpack.yml, dist/prettyscribe.js (committed build artifact), and src/renderer40k10th.ts (superseded by renderer40k10th.tsx). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update jsdom ^19.0.0 → ^28.1.0 and @types/jsdom ^16.2.14 → ^21.1.7 to resolve GHSA-vpq2-c234-7xj6 (via http-proxy-agent/@tootallnate/once)
Fix roster parsers that relied on jsdom 19's non-spec-compliant behavior where element.querySelectorAll("tagname>child") incorrectly matched the context element itself against the leading tagname. jsdom 28 is now spec-compliant and only searches descendants.
Changed all ParseSelections/ParseUnits calls from: root.querySelectorAll("force>selections>selection") to the spec-compliant equivalent using :scope or nested-force selectors.
roster40k.ts uses a combined selector to also capture nested detachment forces (multi-detachment rosters embed a second force inside the first).