Material Icons: Ensure icons in the private use area (fixes #365)#772
Material Icons: Ensure icons in the private use area (fixes #365)#772earboxer wants to merge 1 commit intoryanoasis:masterfrom
Conversation
a0e15df to
000ca5b
Compare
|
This just is the technical aspect, Edit: Docu is not reachable via PR ... |
|
This MR does not implement Plan Plus as per #365 (comment). But I like this MR, as it finally tries to get some momentum going in this issue :-) One question for @earboxer: You say there are new/updated Material icons available. Did you by chance check if they move codepoints? Font Logos does it :-( (lukas-w/font-logos#72). |
|
@Finii Yeah, they (Templarian) moved the codepoints to starting at 0f0001. It looks like the layout is roughly the same, but many breaking changes (replaced icons). e.g. 0f002e is now a pair of rollerblades instead of nf-mdi-amazon_clouddrive (which was f02e in the older source). But then when we get to the bottom of the code page, nf-mdi-home_heart is at 0F0827, where it was previously at F826. Scrolling back through the icons, it seems the 'off-by-one' discrepancy between the old and new sheets starts at F675 (which is now starting at 0F0676), nf-mdi-credit_card_plus. (This is comparing our installed file against v6.5.95, downloaded from their website) |
|
@Finii What all needs to be updated? I see |
I thought about the documentation, but as I try to link here, that is in another repo / wiki... |
Description
This is following @delphinus "Plan 2" in #365
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Build the font and notice that:
Any background context you can provide?
It should be noticed that the material icons we are using are an older version of https://github.com/Templarian/MaterialDesign (it now has 6675 icons).
Google also has a newer version at https://github.com/google/material-design-icons (They have 2142 code points in their Regular font (no variants), which includes some codepoints with semantic meaning but identical appearance (our nf-mdi-sim_alert looks the same as their sim_card_alert and sd_card_alert))
both of these have added several new icons, but they've also removed icons such as nf-mdi-pinterest and nf-mdi-pinterest_box (which notably are redundant with the fontawesome icons nf-fa-pinterest_p and nf-fa-pinterest_square).
While the merge request is moving the code points, you could view this merge request as doing two things:
What are the relevant tickets (if any)?
Fixes #365