Load power of the PowerStrip fixed and removed from the Plug by syssi · Pull Request #117 · rytilahti/python-miio

syssi · 2017-11-08T07:13:10Z

Property load_power removed from the plug. It's a feature of the PowerStrip. The Xiaomi plug doesn't provide load.
Load power workaround of the PowerStrip replaced by a property called "power_consume_rate" which provides the same values as the android app.

houndci-bot · 2017-11-08T07:13:16Z

miio/powerstrip.py

    def status(self) -> PowerStripStatus:
        """Retrieve properties."""
-        properties = ['power', 'temperature', 'current', 'mode']
+        properties = ['power', 'temperature', 'current', 'mode', 'power_consume_rate']


line too long (86 > 79 characters)

…rStrip. The Xiaomi plug doesn't provide load. Load power workaround of the PowerStrip replaced by a property called "power_consume_rate" which provides the same values as the android app.

Unittest of the Plug updated.

houndci-bot · 2017-11-19T09:15:05Z

miio/tests/test_powerstrip.py

+
+        assert self.is_on() is True
+        assert self.state().temperature == self.device.start_state["temperature"]
+        assert self.state().load_power == self.device.start_state["power_consume_rate"]


line too long (87 > 79 characters)

houndci-bot · 2017-11-19T09:15:05Z

miio/tests/test_powerstrip.py

+        self.device._reset_state()
+
+        assert self.is_on() is True
+        assert self.state().temperature == self.device.start_state["temperature"]


line too long (81 > 79 characters)

houndci-bot · 2017-11-19T09:15:06Z

miio/tests/test_powerstrip.py

+
+        assert self.is_on() is True
+        assert self.state().temperature == self.device.start_state["temperature"]
+        assert self.state().load_power == self.device.start_state["power_consume_rate"]


line too long (87 > 79 characters)

houndci-bot · 2017-11-19T09:15:06Z

miio/tests/test_powerstrip.py

+        self.device._reset_state()
+
+        assert self.is_on() is True
+        assert self.state().temperature == self.device.start_state["temperature"]


line too long (81 > 79 characters)

houndci-bot · 2017-11-19T09:15:06Z

miio/tests/test_powerstrip.py

+
+        assert self.is_on() is True
+        assert self.state().temperature == self.device.start_state["temperature"]
+        assert self.state().load_power == self.device.start_state["power_consume_rate"]


line too long (87 > 79 characters)

houndci-bot · 2017-11-19T09:15:06Z

miio/tests/test_powerstrip.py

+        self.device._reset_state()
+
+        assert self.is_on() is True
+        assert self.state().temperature == self.device.start_state["temperature"]


line too long (81 > 79 characters)

coveralls · 2017-11-19T15:37:43Z

Coverage increased (+1.09%) to 46.038% when pulling 537b655 on syssi:feature/powerstrip-power-consume-rate into c51e8cc on rytilahti:master.

houndci-bot · 2017-11-19T15:45:18Z

miio/tests/test_powerstrip.py

+        assert self.state().temperature == \
+               self.device.start_state["temperature"]
+        assert self.state().load_power == \
+               self.device.start_state["power_consume_rate"]


continuation line over-indented for visual indent

houndci-bot · 2017-11-19T15:45:18Z

miio/tests/test_powerstrip.py

+
+        assert self.is_on() is True
+        assert self.state().temperature == \
+               self.device.start_state["temperature"]


continuation line over-indented for visual indent

houndci-bot · 2017-11-19T15:45:18Z

miio/tests/test_powerstrip.py

+        assert self.state().temperature == \
+               self.device.start_state["temperature"]
+        assert self.state().load_power == \
+               self.device.start_state["power_consume_rate"]


continuation line over-indented for visual indent

houndci-bot · 2017-11-19T15:45:18Z

miio/tests/test_powerstrip.py

+
+        assert self.is_on() is True
+        assert self.state().temperature == \
+               self.device.start_state["temperature"]


continuation line over-indented for visual indent

coveralls · 2017-11-19T15:46:39Z

Coverage increased (+1.09%) to 46.038% when pulling 921bb71 on syssi:feature/powerstrip-power-consume-rate into c51e8cc on rytilahti:master.

coveralls · 2017-11-19T15:50:29Z

Coverage increased (+1.09%) to 46.038% when pulling 024c147 on syssi:feature/powerstrip-power-consume-rate into c51e8cc on rytilahti:master.

rytilahti · 2017-11-19T15:58:45Z

Yay for coverage increase too, thanks :-)

houndci-bot reviewed Nov 8, 2017

View reviewed changes

syssi added 2 commits November 19, 2017 09:20

Property load_power removed from the plug. It's a feature of the Powe…

47d59ac

…rStrip. The Xiaomi plug doesn't provide load. Load power workaround of the PowerStrip replaced by a property called "power_consume_rate" which provides the same values as the android app.

Line too long fixed.

44358b7

syssi force-pushed the feature/powerstrip-power-consume-rate branch from 7da0280 to 44358b7 Compare November 19, 2017 08:21

Unittest for the PowerStrip added.

ebac318

Unittest of the Plug updated.

houndci-bot reviewed Nov 19, 2017

View reviewed changes

syssi added 2 commits November 19, 2017 10:57

Fixture updated.

1c09337

Fixture updated. Missing property ("mode") added.

537b655

Make hound happy again.

921bb71

houndci-bot reviewed Nov 19, 2017

View reviewed changes

The hound error is fine for better readability of the assertion.

024c147

rytilahti merged commit beeef6a into rytilahti:master Nov 19, 2017

Uh oh!

Conversation

syssi commented Nov 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rytilahti commented Nov 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Nov 19, 2017 •

edited

Loading

coveralls commented Nov 19, 2017 •

edited

Loading

coveralls commented Nov 19, 2017 •

edited

Loading