Don’t require typing with Python 3.5 and newer#123
Merged
rytilahti merged 1 commit intorytilahti:masterfrom Nov 18, 2017
pluehne:patrick/python-3.5
Merged
Don’t require typing with Python 3.5 and newer#123rytilahti merged 1 commit intorytilahti:masterfrom pluehne:patrick/python-3.5
rytilahti merged 1 commit intorytilahti:masterfrom
pluehne:patrick/python-3.5
Conversation
Python 3.5 and newer ship with built-in typing support. For this reason, there is no need to require the typing package starting from Python 3.5.
Owner
|
Looks good and reasonable, adding that requirement so hastily (and keeping support for py < 3.5) was not properly motivated choice. I think it would actually be fair enough to drop support for py < 3.5 considering Debian stable is also already on it, but let's leave it like that for the time being and merge this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.5 and newer ship with built-in typing support. For this reason, there is no need to require the
typingpackage starting from Python 3.5.On Arch Linux, this requirement caused trouble, because Arch Linux doesn’t provide the
typingpackage anymore, as it is deemed unnecessary now. For this reason,python-miiocomplains about the missingtypingdependency without this adjustment.