Skip to content

Unbreak the communication when using construct v2.8.17#142

Merged
rytilahti merged 1 commit intomasterfrom
fix_protocol
Dec 15, 2017
Merged

Unbreak the communication when using construct v2.8.17#142
rytilahti merged 1 commit intomasterfrom
fix_protocol

Conversation

@rytilahti
Copy link
Copy Markdown
Owner

  • Removes usage of Enum (construct internals were changed, and this is the simplest way to fix it)
  • devtype and devserial are now just "device_id", as the values of those fields are not really known

Fixes checksum issue seen in home-assistant/core#11048 - related to construct/construct#416 .

* Removes usage of Enum (construct internals were changed, and this is the simplest way to fix it)
* devtype and devserial are now just "device_id", as the values of those fields are not really known
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 13, 2017

Coverage Status

Coverage decreased (-0.003%) to 63.082% when pulling 1006443 on fix_protocol into 6ebbbbc on master.

@fanthos
Copy link
Copy Markdown
Contributor

fanthos commented Dec 14, 2017

I had the same problem when test my new device with Home Assistant.
Simply change "devtype" in protocol.py from Enum to Default fix the issue.
Combining devtype and serial should be a good idea.

@rytilahti
Copy link
Copy Markdown
Owner Author

Ok, thanks for testing, let's get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants