Skip to content

Philips Bulb crashs if _id is 0#211

Merged
syssi merged 1 commit intorytilahti:masterfrom
syssi:feature/philips-bulb-crashs-sequence-number-crash
Feb 12, 2018
Merged

Philips Bulb crashs if _id is 0#211
syssi merged 1 commit intorytilahti:masterfrom
syssi:feature/philips-bulb-crashs-sequence-number-crash

Conversation

@syssi
Copy link
Copy Markdown
Collaborator

@syssi syssi commented Feb 10, 2018

The range [1,9999] and wrap around works fine.

@rytilahti Could you verify this change works for your vacuum too? Just manipulate the ~/.cache/python-miio/python-mirobo.seq (seq=9998) and try a few "get_prop" requests.

@rytilahti
Copy link
Copy Markdown
Owner

Seems to work fine for me, feel free to merge.

Looking into the log file inside the robot, this is what I'm seeing when the timeouts happen:

[20180211 21:11:07] [INFO] OT protocol diagrams come...
[20180211 21:11:07] [INFO] Fill my DID
[20180211 21:11:07] [INFO] Fill my TIMESTAMP
[20180211 21:11:08] [INFO] OT protocol diagrams come...
[20180211 21:11:08] [DEBUG] look like a repeated msg:-3,2
[20180211 21:11:13] [INFO] OT protocol diagrams come...
[20180211 21:11:13] [INFO] Fill my DID
[20180211 21:11:13] [INFO] Fill my TIMESTAMP
[20180211 21:11:13] [INFO] OT protocol diagrams come...
[20180211 21:11:13] [DEBUG] look like a repeated msg:-3,103
[20180211 21:11:18] [INFO] OT protocol diagrams come...
[20180211 21:11:18] [INFO] Fill my DID                                                                                                
[20180211 21:11:18] [INFO] Fill my TIMESTAMP               

look like a repeated msg:-3,2 is the key here, in this case 2 and the next one 103 indicate the sequence number, no idea what -3 is, but looks like just bumping the sequence number is not a real solution... The payloads for those requests were {'method': 'get_status', 'id': 2} and {'method': 'get_status', 'id': 103}.

@syssi syssi changed the title Philips Bulb crashs if _id=0 Philips Bulb crashs if _id is 0 Feb 12, 2018
@syssi syssi merged commit cd1f6dc into rytilahti:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants