Chuangmi IR: Fix Construct 2.9.28 regresion#214
Merged
syssi merged 1 commit intorytilahti:masterfrom Feb 12, 2018
Merged
Conversation
Contributor
|
This wasnt Construct regression, it was providing a float instead of integer. It was working fine by sheer luck. |
Contributor
|
See #222 . |
Contributor
Author
|
@arekbulski Sorry, the wording could be better. It was not my intention to say that it was a regression within the Construct, but rather in my code against newer version of it. |
Contributor
|
Thats fine, thanks for explaining. The other PR #220 that fixes adapter path parameter needs some rework, but thats a different matter. |
Collaborator
|
I will care about the path parameter. |
Contributor
|
#220 has three commits, if you could just undo the 2nd commit, that would work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #212
Tested against Construct versions 2.9.27, 2.9.28 and 2.9.29.