Merged
Conversation
1 similar comment
Owner
Thanks for extending the support :-) The mode is missing on this device, and the temperature output is probably used for something else as that temperature does not make sense. |
Collaborator
Author
|
Could you try to set a float? |
Collaborator
Author
would be interesting too. Do you have the 1st or 2gen of the powerstrip? |
Owner
|
It accepts floats, but rounds them down: Values with quotes is not accepted and will result in This is the v2 of zimi: |
The power mode can be None.
houndci-bot
reviewed
Feb 27, 2018
miio/tests/test_powerstrip.py
Outdated
| self.device.set_power_mode(PowerMode.Normal) | ||
| assert mode() == PowerMode.Normal | ||
|
|
||
| def test_status_without_mode(self): |
There was a problem hiding this comment.
redefinition of unused 'test_status_without_mode' from line 80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New properties and commands added: wifi_led, power_price.
@rytilahti Could you provide a response example for
Thanks!