Support for the Xiaomi Mi WiFi Repeater 2 added#278
Merged
syssi merged 5 commits intorytilahti:masterfrom Mar 26, 2018
Merged
Conversation
houndci-bot
reviewed
Mar 26, 2018
| def test_configuration(self): | ||
| self.device._reset_state() | ||
|
|
||
| assert repr(self.configuration()) == repr(WifiRepeaterConfiguration(self.device.start_config)) |
There was a problem hiding this comment.
line too long (102 > 100 characters)
rytilahti
approved these changes
Mar 26, 2018
Owner
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Just one question, otherwise feel free to merge! 👍
| self.data = data | ||
|
|
||
| @property | ||
| def access_policy(self) -> int: |
Owner
There was a problem hiding this comment.
Is it known what this integer represents?
Collaborator
Author
There was a problem hiding this comment.
Unfortunately, no. My assumption is the connectivity between the clients. I cannot be controlled at the moment. The method is unknown / unused of the Mi Home app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation is the foundation for the xiaomi miio device tracker: https://github.com/syssi/xiaomi_repeater
(Closes: #275)