Basic support for Xiaomi Mi Smart Electric Rice Cooker by syssi · Pull Request #287 · rytilahti/python-miio

syssi · 2018-03-29T18:23:07Z

Closes: #282

houndci-bot · 2018-03-29T18:23:16Z

miio/cooker.py

+                MODEL_NORMAL5]
+
+
+class OperationMode(enum.Enum):


undefined name 'enum'

houndci-bot · 2018-03-29T18:23:16Z

miio/cooker.py

@@ -0,0 +1,199 @@
+import logging
+from collections import defaultdict
+from .device import Device, DeviceException


'.device.DeviceException' imported but unused

coveralls · 2018-03-29T18:41:13Z

Coverage decreased (-0.01%) to 71.06% when pulling a59ae33 on syssi:feature/xiaomi-cooker into 056954c on rytilahti:master.

coveralls · 2018-03-29T18:41:13Z

Coverage decreased (-1.0%) to 72.143% when pulling 7d272fa on syssi:feature/xiaomi-cooker into 76a2dd2 on rytilahti:master.

houndci-bot · 2018-03-30T05:25:01Z

miio/cooker.py

+MODEL_NORMAL_GROUP1 = [MODEL_NORMAL2, MODEL_NORMAL5]
+MODEL_NRRMAL_GROUP2 = [MODEL_NORMAL3, MODEL_NORMAL4]
+
+class OperationMode(enum.Enum):


expected 2 blank lines, found 1

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+        operate at full load to boil rice: ['running',      '0001', '06000000ff', '031e0b23',     '29', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010006015c64']
+        high temperature gelatinization:   ['running',      '0001', '07000000ff', '031e0b23',     '22', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010007015d64']
+        temperature gelatinization:        ['running',      '0001', '0a000000ff', '031e0b23',     '2',  '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff01000a015559']
+        meal is ready:                     ['autokeepwarm', '0001', '1000000000', '031e0b23031e', '1', '750', '60', '0207', '05040f', '00030017', '0100', 'ffffffffffff011effff01000000535d']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+        operate at full load to boil rice: ['running',      '0001', '04000000ff', '031e0b23',     '35', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010004026460']
+        operate at full load to boil rice: ['running',      '0001', '06000000ff', '031e0b23',     '29', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010006015c64']
+        high temperature gelatinization:   ['running',      '0001', '07000000ff', '031e0b23',     '22', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010007015d64']
+        temperature gelatinization:        ['running',      '0001', '0a000000ff', '031e0b23',     '2',  '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff01000a015559']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+        operate at full load to boil rice: ['running',      '0001', '03000000ff', '031e0b23',     '39', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010003055332']
+        operate at full load to boil rice: ['running',      '0001', '04000000ff', '031e0b23',     '35', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010004026460']
+        operate at full load to boil rice: ['running',      '0001', '06000000ff', '031e0b23',     '29', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010006015c64']
+        high temperature gelatinization:   ['running',      '0001', '07000000ff', '031e0b23',     '22', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010007015d64']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '48', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010002013f29']
+        operate at full load to boil rice: ['running',      '0001', '03000000ff', '031e0b23',     '39', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010003055332']
+        operate at full load to boil rice: ['running',      '0001', '04000000ff', '031e0b23',     '35', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010004026460']
+        operate at full load to boil rice: ['running',      '0001', '06000000ff', '031e0b23',     '29', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010006015c64']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '54', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010002013e23']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '48', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010002013f29']
+        operate at full load to boil rice: ['running',      '0001', '03000000ff', '031e0b23',     '39', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010003055332']
+        operate at full load to boil rice: ['running',      '0001', '04000000ff', '031e0b23',     '35', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010004026460']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+        quickly preheat:                   ['running',      '0001', '00000000ff', '031e0b23',     '60', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010000001d1f']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '54', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010002013e23']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '48', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010002013f29']
+        operate at full load to boil rice: ['running',      '0001', '03000000ff', '031e0b23',     '39', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010003055332']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+        idle:                              ['waiting',      '0001', 'null',             '29',     '60', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010000001d1f']
+        quickly preheat:                   ['running',      '0001', '00000000ff', '031e0b23',     '60', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010000001d1f']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '54', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010002013e23']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '48', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010002013f29']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+        """
+        idle:                              ['waiting',      '0001', 'null',             '29',     '60', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010000001d1f']
+        quickly preheat:                   ['running',      '0001', '00000000ff', '031e0b23',     '60', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010000001d1f']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '54', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010002013e23']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+    def stage(self) -> str:
+        """
+        idle:                              ['waiting',      '0001', 'null',             '29',     '60', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010000001d1f']
+        quickly preheat:                   ['running',      '0001', '00000000ff', '031e0b23',     '60', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010000001d1f']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:04:18Z

miio/cooker.py

+    @property
+    def stage(self) -> str:
+        """
+        idle:                              ['waiting',      '0001', 'null',             '29',     '60', '-1', '60', '0607', '05040f', '00030017', '0100', 'ffffffffffff011effff010000001d1f']


line too long (189 > 100 characters)

houndci-bot · 2018-03-30T06:10:55Z

miio/cooker.py

+        operate at full load to boil rice: ['running',      '0001', '06000000ff', '031e0b23',     '29',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010006015c64']
+        high temperature gelatinization:   ['running',      '0001', '07000000ff', '031e0b23',     '22',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010007015d64']
+        temperature gelatinization:        ['running',      '0001', '0a000000ff', '031e0b23',     '2',       '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff01000a015559']
+        meal is ready:                     ['autokeepwarm', '0001', '1000000000', '031e0b23031e', '1',      '750',   '60',  '0207', '05040f', '00030017',   '0100', 'ffffffffffff011effff01000000535d']


line too long (199 > 100 characters)

houndci-bot · 2018-03-30T06:10:55Z

miio/cooker.py

+        operate at full load to boil rice: ['running',      '0001', '04000000ff', '031e0b23',     '35',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010004026460']
+        operate at full load to boil rice: ['running',      '0001', '06000000ff', '031e0b23',     '29',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010006015c64']
+        high temperature gelatinization:   ['running',      '0001', '07000000ff', '031e0b23',     '22',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010007015d64']
+        temperature gelatinization:        ['running',      '0001', '0a000000ff', '031e0b23',     '2',       '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff01000a015559']


line too long (199 > 100 characters)

houndci-bot · 2018-03-30T06:10:56Z

miio/cooker.py

+        operate at full load to boil rice: ['running',      '0001', '03000000ff', '031e0b23',     '39',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010003055332']
+        operate at full load to boil rice: ['running',      '0001', '04000000ff', '031e0b23',     '35',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010004026460']
+        operate at full load to boil rice: ['running',      '0001', '06000000ff', '031e0b23',     '29',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010006015c64']
+        high temperature gelatinization:   ['running',      '0001', '07000000ff', '031e0b23',     '22',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010007015d64']


line too long (199 > 100 characters)

houndci-bot · 2018-03-30T06:10:56Z

miio/cooker.py

+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '48',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010002013f29']
+        operate at full load to boil rice: ['running',      '0001', '03000000ff', '031e0b23',     '39',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010003055332']
+        operate at full load to boil rice: ['running',      '0001', '04000000ff', '031e0b23',     '35',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010004026460']
+        operate at full load to boil rice: ['running',      '0001', '06000000ff', '031e0b23',     '29',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010006015c64']


line too long (199 > 100 characters)

houndci-bot · 2018-03-30T06:10:56Z

miio/cooker.py

+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '54',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010002013e23']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '48',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010002013f29']
+        operate at full load to boil rice: ['running',      '0001', '03000000ff', '031e0b23',     '39',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010003055332']
+        operate at full load to boil rice: ['running',      '0001', '04000000ff', '031e0b23',     '35',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010004026460']


line too long (199 > 100 characters)

houndci-bot · 2018-03-30T06:10:56Z

miio/cooker.py

+        idle:                              ['waiting',      '0001', 'null',             '29',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']
+        quickly preheat:                   ['running',      '0001', '00000000ff', '031e0b23',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '54',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010002013e23']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '48',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010002013f29']


line too long (199 > 100 characters)

houndci-bot · 2018-03-30T06:10:56Z

miio/cooker.py

+                                              func   ,       menu ,    stage    ,    temp   ,   t_func, t_precook, t_cook, setting,   delay ,  version  , favorite,               custom
+        idle:                              ['waiting',      '0001', 'null',             '29',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']
+        quickly preheat:                   ['running',      '0001', '00000000ff', '031e0b23',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '54',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010002013e23']


line too long (199 > 100 characters)

houndci-bot · 2018-03-30T06:10:56Z

miio/cooker.py

+        """
+                                              func   ,       menu ,    stage    ,    temp   ,   t_func, t_precook, t_cook, setting,   delay ,  version  , favorite,               custom
+        idle:                              ['waiting',      '0001', 'null',             '29',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']
+        quickly preheat:                   ['running',      '0001', '00000000ff', '031e0b23',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']


line too long (199 > 100 characters)

houndci-bot · 2018-03-30T06:10:56Z

miio/cooker.py

+    def stage(self) -> str:
+        """
+                                              func   ,       menu ,    stage    ,    temp   ,   t_func, t_precook, t_cook, setting,   delay ,  version  , favorite,               custom
+        idle:                              ['waiting',      '0001', 'null',             '29',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']


line too long (199 > 100 characters)

houndci-bot · 2018-03-30T06:10:56Z

miio/cooker.py

+    @property
+    def stage(self) -> str:
+        """
+                                              func   ,       menu ,    stage    ,    temp   ,   t_func, t_precook, t_cook, setting,   delay ,  version  , favorite,               custom


line too long (184 > 100 characters)

houndci-bot · 2018-03-31T14:36:22Z

miio/cooker.py

+                                              func   ,       menu ,    stage    ,    temp   ,   t_func, t_precook, t_cook, setting,   delay ,  version  , favorite,               custom
+        idle:                              ['waiting',      '0001', 'null',             '29',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']
+        quickly preheat:                   ['running',      '0001', '00000000ff', '031e0b23',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']
+        absorb water at moderate temp:     ['running',      '0001', '02000000ff', '031e0b23',     '54',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010002013e23']


line too long (199 > 100 characters)

houndci-bot · 2018-03-31T14:36:22Z

miio/cooker.py

+
+                                              func   ,       menu ,    stage    ,    temp   ,   t_func, t_precook, t_cook, setting,   delay ,  version  , favorite,               custom
+        idle:                              ['waiting',      '0001', 'null',             '29',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']
+        quickly preheat:                   ['running',      '0001', '00000000ff', '031e0b23',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']


line too long (199 > 100 characters)

houndci-bot · 2018-03-31T14:36:22Z

miio/cooker.py

+          'custom': '13281323ffff011effff010000001617'}
+
+                                              func   ,       menu ,    stage    ,    temp   ,   t_func, t_precook, t_cook, setting,   delay ,  version  , favorite,               custom
+        idle:                              ['waiting',      '0001', 'null',             '29',     '60',      '-1',   '60',  '0607', '05040f', '00030017',   '0100', 'ffffffffffff011effff010000001d1f']


line too long (199 > 100 characters)

houndci-bot · 2018-03-31T14:36:22Z

miio/cooker.py

+          'favorite': '0100',
+          'custom': '13281323ffff011effff010000001617'}
+
+                                              func   ,       menu ,    stage    ,    temp   ,   t_func, t_precook, t_cook, setting,   delay ,  version  , favorite,               custom


line too long (184 > 100 characters)

houndci-bot · 2018-03-31T16:49:39Z

miio/cooker.py

+        s = "<TemperatureHistory temperatures=%s>" % self.data
+        return s
+
+class CookerCustomizations:


expected 2 blank lines, found 1

rytilahti

Looks good in general. Consider the amount of classes and LOC, I'm wondering if this should be split into multiple files (and if we should start adding some structure into the source dir in these cases); miio/vacuum/ for vacuum, miio/cooker/ for cooker etc. What do you think?

rytilahti · 2018-04-02T13:39:14Z

miio/cooker.py

+MODEL_NORMAL_GROUP1 = [MODEL_NORMAL2, MODEL_NORMAL5]
+MODEL_NRRMAL_GROUP2 = [MODEL_NORMAL3, MODEL_NORMAL4]
+
+COOKING_STAGE_NAME = [


Please merge this and cooking state descriptions into a dict.

rytilahti · 2018-04-02T13:40:14Z

miio/cooker.py

+        self.data = [int(data[i:i + 2], 16) for i in range(0, len(data), 2)]
+
+    @property
+    def temperatures(self) -> list[int]:


You need to from typing import List and use List here (and elsewhere).

rytilahti · 2018-04-02T13:41:18Z

miio/cooker.py

+    Cancel = 'Отмена'
+
+
+class TemperatureHistory:


doctstrings would be nice for this class, too. What does this dow and how can I use it? It's a container of temperatures recorded every X time interval? Is there a limit how many historical values are available?

rytilahti · 2018-04-02T13:42:07Z

miio/cooker.py

+    ResumeP = 'resumep'
+    Start = 'start'
+    StartP = 'startp'
+    Cancel = 'Отмена'


That looks weird. What does it mean that they are potential candidates? Is it necessary that these are included?

These are possible values of the property "func". A few are internal states of the android app probably. I've just collected all occurrences of string comparisons.

rytilahti · 2018-04-02T13:43:16Z

miio/cooker.py

+        """
+        Example values:
+
+        ffffffffffff011effff010000001d1f,


It would be nice to have some sort of short description for the bytes / how to interpret these.

rytilahti · 2018-04-02T13:48:00Z

miio/cooker.py

+        if len(value) == 2 and value.isdigit():
+            return int(value)
+
+        return None


Exception instead of returning None here too? (and below also, for error cases)

If the cooker isn't cooking it returns the room temperature here (property: "temp").

Ok, what are the values otherwise? Those hex-encoded ones? Should this be printing a warning when used and the temperature is not available, and point out what to do instead of it?

Note: Discussed at discord.

rytilahti · 2018-04-02T13:49:26Z

miio/cooker.py

+    @command(
+        default_output=format_output("Cooking stopped"),
+    )
+    def stop_outdated_firmware(self):


Is it possible to check if outdated stop is necessary, and just expose the stop command?

It's possible but ugly. I've to compare a lot of firmware versions and model types. It was to complicated to implement at the first step.

Ok, then let it be like that for now.

rytilahti · 2018-04-02T13:52:33Z

miio/cooker.py

+MODEL_NORMAL3 = 'chunmi.cooker.normal4'
+MODEL_NORMAL5 = 'chunmi.cooker.normal5'
+
+MODEL_PRESSURE = [MODEL_PRESSURE1, MODEL_PRESSURE2]


If MODEL_PRESSURE{1,2} are used nowehere else than here, better just simply use them instead of exposing a global variable.

These consts are important in future for all the edge-cases.

rytilahti · 2018-04-02T13:54:17Z

miio/cooker.py

+                MODEL_NORMAL5]
+
+MODEL_NORMAL_GROUP1 = [MODEL_NORMAL2, MODEL_NORMAL5]
+MODEL_NRRMAL_GROUP2 = [MODEL_NORMAL3, MODEL_NORMAL4]


Typo in nrrmal. MODEL_NORMAL1 does not belong to any group? Are these global variables necessary?

rytilahti · 2018-04-02T13:56:02Z

miio/cooker_profiles.json

@@ -0,0 +1,195 @@
+{


Maybe miio/data/cooker_profiles.json to keep it from polluting the main source dir?

To add, the setup.py and/or manifest file will require also an update, otherwise the json file won't be added when generating a package.

Typing List added

houndci-bot · 2018-04-19T06:31:35Z

miio/cooker.py

+
+import click
+
+from .click_common import command, format_output, EnumType


'.click_common.EnumType' imported but unused

houndci-bot reviewed Mar 29, 2018

View reviewed changes

houndci-bot reviewed Mar 30, 2018

View reviewed changes

houndci-bot reviewed Mar 31, 2018

View reviewed changes

syssi force-pushed the feature/xiaomi-cooker branch from e941fb0 to 5fad578 Compare March 31, 2018 16:28

houndci-bot reviewed Mar 31, 2018

View reviewed changes

syssi changed the title ~~WIP: First draft of the Xiaomi Cooker support~~ Support for Xiaomi Mi Smart Electric Rice Cooker Mar 31, 2018

syssi added 20 commits March 31, 2018 23:27

First draft of the Xiaomi Cooker support

efd5bb9

Missing import added

6e9f18f

Cooker profiles added

f83c979

Typo fixed

a6feafc

Docstring updated

1999e76

Throw an exception if the cooking profile is invalid

5b4e126

Some observations added

f74fe2c

Format improved and caption added

e690a62

Cooker settings added

abf7e47

Use the new settings at set_interaction

0b2b560

Set interaction is feature complete

ec88e71

FIXMEs added

22957b3

Refactoring

6fa24f3

Repr fixed

d63b8b5

Refactoring

b3515b8

Cooking stages added

6e138d5

Refactoring and cooker customizations added

4d723da

Typos fixed

032e662

Clean-up and some docstrings added

d7f4a41

Support of the temperature property extended

d1b9d5e

syssi added 4 commits March 31, 2018 23:27

Stages translated

0e133e8

Temperature history added

089a711

Missing blank line added

1d322aa

Translations updated

a2b0412

syssi force-pushed the feature/xiaomi-cooker branch from 5b5cc97 to a2b0412 Compare March 31, 2018 21:27

Unified cli support added

3ea64fc

rytilahti reviewed Apr 2, 2018

View reviewed changes

syssi changed the title ~~Support for Xiaomi Mi Smart Electric Rice Cooker~~ WIP: Support for Xiaomi Mi Smart Electric Rice Cooker Apr 2, 2018

syssi and others added 8 commits April 15, 2018 19:57

README updated

2034fd8

Taste phase fixed

1d4e0fd

Typing List added

Typo fixed

3e8d549

Cooking profiles moved to data directory

842a23f

Include package data

2bda04f

Merge branch 'master' into feature/xiaomi-cooker

0b27bd0

WifiSpeaker import removed by accident

18adea2

Incomplete CLI code removed

5de4107

houndci-bot reviewed Apr 19, 2018

View reviewed changes

syssi added 2 commits April 19, 2018 08:33

Unused import removed

30ade06

Description of the data structures added

7d272fa

syssi changed the title ~~WIP: Support for Xiaomi Mi Smart Electric Rice Cooker~~ Basic support for Xiaomi Mi Smart Electric Rice Cooker Apr 19, 2018

syssi merged commit e8b6489 into rytilahti:master Apr 19, 2018


		import click

		from .click_common import command, format_output, EnumType

Uh oh!

Conversation

syssi commented Mar 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Mar 29, 2018

Uh oh!

coveralls commented Mar 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

syssi commented Mar 29, 2018 •

edited

Loading

coveralls commented Mar 29, 2018 •

edited

Loading