Skip to content

Air Quality Monitor: Type and payload example of the time_state property updated #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 1 commit into from
Apr 1, 2018
Merged

Air Quality Monitor: Type and payload example of the time_state property updated #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions miio/airqualitymonitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
class AirQualityMonitorStatus:
"""Container of air quality monitor status."""
def __init__(self, data):
# {'power': 'on', 'aqi': 34, 'battery': 100, 'usb_state': 'off'}
# {'power': 'on', 'aqi': 34, 'battery': 100, 'usb_state': 'off', 'time_state': 'on'}
self.data = data

@property
Expand Down Expand Up @@ -37,9 +37,9 @@ def battery(self) -> int:
return self.data["battery"]

@property
def time_state(self) -> str:
def time_state(self) -> bool:
"""Current time state."""
return self.data["time_state"]
return self.data["time_state"] == "on"

def __repr__(self) -> str:
s = "<AirQualityMonitorStatus power=%s, " \
Expand Down
6 changes: 3 additions & 3 deletions miio/tests/test_airqualitymonitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def __init__(self, *args, **kwargs):
'aqi': 34,
'battery': 100,
'usb_state': 'off',
'time_state': 'format unknown'
'time_state': 'on'
}
self.return_values = {
'get_prop': self._get_state,
Expand Down Expand Up @@ -57,5 +57,5 @@ def test_status(self):
assert self.is_on() is True
assert self.state().aqi == self.device.start_state["aqi"]
assert self.state().battery == self.device.start_state["battery"]
assert self.state().usb_power == (self.device.start_state["usb_state"] == 'on')
assert self.state().time_state == self.device.start_state["time_state"]
assert self.state().usb_power is (self.device.start_state["usb_state"] == 'on')
assert self.state().time_state is (self.device.start_state["time_state"] == 'on')