Fix a name clash of click_common and the argument "command"#328
Merged
syssi merged 1 commit intorytilahti:masterfrom Jun 2, 2018
Merged
Fix a name clash of click_common and the argument "command"#328syssi merged 1 commit intorytilahti:masterfrom
syssi merged 1 commit intorytilahti:masterfrom
Conversation
Collaborator
Author
|
@yawor Is a rename of the variable a proper approach? A leading underscore looks weird. |
Contributor
|
Rename either that or the "command" argument in chuangmi_ir to "ir_command" or something like that. |
Collaborator
Author
|
There are some more methods with a parameter called "command". That's the cause, why I choose this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
of device methods (Closes: #325)