Merged
Conversation
houndci-bot
reviewed
Sep 3, 2017
| # It looks like philips devices cannot be discovered via mdns | ||
| "philips-light-bulb": Ceil, | ||
| "philips-light-ceil": Ceil, | ||
| "philips-light-sread1": PhilipsEyecare, |
| #"yunmi-waterpuri-v2": WaterPurifier, | ||
| # It looks like philips devices cannot be discovered via mdns | ||
| "philips-light-bulb": Ceil, | ||
| "philips-light-ceil": Ceil, |
| #"zhimi-humidifier-v1": Humidifier, | ||
| #"yunmi-waterpuri-v2": WaterPurifier, | ||
| # It looks like philips devices cannot be discovered via mdns | ||
| "philips-light-bulb": Ceil, |
mirobo/discovery.py
Outdated
| "zhimi-airpurifier-v3": AirPurifier, | ||
| "zhimi-airpurifier-v6": AirPurifier, | ||
| #"zhimi-humidifier-v1": Humidifier, | ||
| #"yunmi-waterpuri-v2": WaterPurifier, |
There was a problem hiding this comment.
block comment should start with '# '
mirobo/discovery.py
Outdated
| "zhimi-airpurifier-v2": AirPurifier, | ||
| "zhimi-airpurifier-v3": AirPurifier, | ||
| "zhimi-airpurifier-v6": AirPurifier, | ||
| #"zhimi-humidifier-v1": Humidifier, |
There was a problem hiding this comment.
block comment should start with '# '
mirobo/discovery.py
Outdated
| "chuangmi-plug-v2": Plug, | ||
| "qmi-powerstrip-v1": Strip, | ||
| "zimi.powerstrip.v2": Strip, | ||
| "chuangmi-plug-v1": PlugV1, |
| "chuangmi-plug-m1": Plug, | ||
| "chuangmi-plug-v2": Plug, | ||
| "qmi-powerstrip-v1": Strip, | ||
| "zimi.powerstrip.v2": Strip, |
| "rockrobo-vacuum-v1": Vacuum, | ||
| "chuangmi-plug-m1": Plug, | ||
| "chuangmi-plug-v2": Plug, | ||
| "qmi-powerstrip-v1": Strip, |
| _mdns_device_map = { | ||
| "rockrobo-vacuum-v1": Vacuum, | ||
| "chuangmi-plug-m1": Plug, | ||
| "chuangmi-plug-v2": Plug, |
| class Discovery: | ||
| _mdns_device_map = { | ||
| "rockrobo-vacuum-v1": Vacuum, | ||
| "chuangmi-plug-m1": Plug, |
houndci-bot
reviewed
Sep 3, 2017
mirobo/discovery.py
Outdated
| import codecs | ||
| from typing import Any, List, Union, Callable | ||
| from mirobo import Message, Device, Vacuum | ||
| from mirobo import Message, Device, Vacuum, Plug, PlugV1, Strip, AirPurifier, Ceil, PhilipsEyecare |
There was a problem hiding this comment.
'mirobo.Message' imported but unused
line too long (98 > 79 characters)
houndci-bot
reviewed
Sep 3, 2017
mirobo/discovery.py
Outdated
| import codecs | ||
| from typing import Any, List, Union, Callable | ||
| from mirobo import Message, Device, Vacuum | ||
| from typing import Union, Callable |
There was a problem hiding this comment.
'typing.Union' imported but unused
'typing.Callable' imported but unused
Collaborator
Author
|
New highscore. 15 complains on 18 lines changed . ;-) Next time I will spin-up the IDE from the very first. |
Owner
|
Thanks a bunch for doing this, it will help to make a nicer device handling possible later on :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.