Conversation
rytilahti
force-pushed
the
extend_yeelight
branch
from
4eea494 to
97d6484
Compare
syssi
approved these changes
Oct 2, 2017
Collaborator
syssi
left a comment
syssi
left a comment
There was a problem hiding this comment.
Could you please add an example response:
python3 ./mirobo --ip 192.168.130.xx --token ffff raw_command get_prop "['power','bright','ct','rgb','hue','sat','color_mode','name','lan_ctrl','save_state']"
['off', '1', '4000', '16777215', '359', '100', '1', '', '1', '0']
Looks good!
Adds more functionality and allows yeelights to be discovered. * set_developer_mode(bool) allows enabling and disabling the developer mode (necessary for python-yeelight etc.) * set_name(str) to set the internal name, note that this is not the same as shown in mobile apps * set_save_state_on_change(bool) to enable saving the current bulb state when doing modifications
Owner
Author
|
Added and fixed conflicts, merging! |
rytilahti
force-pushed
the
extend_yeelight
branch
from
97d6484 to
0965c3d
Compare
houndci-bot
reviewed
Oct 2, 2017
| class YeelightStatus: | ||
| def __init__(self, data): | ||
| # ['power', 'bright', 'ct', 'rgb', 'hue', 'sat', 'color_mode', 'name', 'lan_ctrl', 'save_state'] | ||
| # ['on', '100', '3584', '16711680', '359', '100', '2', 'name', '1', '1'] |
There was a problem hiding this comment.
line too long (102 > 79 characters)
|
|
||
| class YeelightStatus: | ||
| def __init__(self, data): | ||
| # ['power', 'bright', 'ct', 'rgb', 'hue', 'sat', 'color_mode', 'name', 'lan_ctrl', 'save_state'] |
There was a problem hiding this comment.
line too long (111 > 79 characters)
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more functionality and allows yeelights to be discovered.
Note: initialization still causes a warning to recommend python-yeelight, which offers a much nicer API. However, for some users the ability to activate the developer mode with this can be very useful.