Conversation
houndci-bot
reviewed
Oct 1, 2017
mirobo/discovery.py
Outdated
| import codecs | ||
| from . import (Device, Vacuum, Plug, PlugV1, Strip, AirPurifier, Ceil, | ||
| PhilipsEyecare, ChuangmiIr, AirHumidifier, WaterPurifier) | ||
| PhilipsEyecare, ChuangmiIr, AirHumidifier, WaterPurifier, WifiSpeaker) |
houndci-bot
reviewed
Oct 1, 2017
mirobo/discovery.py
Outdated
| import codecs | ||
| from . import (Device, Vacuum, Plug, PlugV1, Strip, AirPurifier, Ceil, | ||
| PhilipsEyecare, ChuangmiIr, AirHumidifier, WaterPurifier) | ||
| PhilipsEyecare, ChuangmiIr, AirHumidifier, WaterPurifier, WifiSpeaker) |
houndci-bot
reviewed
Oct 1, 2017
mirobo/discovery.py
Outdated
| import codecs | ||
| from . import (Device, Vacuum, Plug, PlugV1, Strip, AirPurifier, Ceil, | ||
| PhilipsEyecare, ChuangmiIr, AirHumidifier, WaterPurifier) | ||
| PhilipsEyecare, ChuangmiIr, AirHumidifier, WaterPurifier, WifiSpeaker) |
First steps towards fixing #69, we require feedback from someone who owns the device to complete it.
syssi
approved these changes
Oct 2, 2017
mirobo/wifispeaker.py
Outdated
| def track_next(self): | ||
| return self.send("next_track") | ||
|
|
||
| def track_location(self): |
Collaborator
There was a problem hiding this comment.
I would prefer track_position here.
Owner
Author
There was a problem hiding this comment.
Changed + added some apidocs & fixed the broken status.
| import logging | ||
| from .device import Device | ||
|
|
||
| _LOGGER = logging.getLogger(__name__) |
Owner
Author
There was a problem hiding this comment.
It is not currently, but I think it's ok to leave it like that for now. This will probably need some revisions to be remotely useful, and for that there'll be debug outputs I hope.
…ix invalid send() in status()
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First steps towards fixing #69, we require feedback
from someone who owns the device to complete it.