Creating test user service; Add fraud prevention headers#14
Merged
s-patompong merged 10 commits intos-patompong:masterfrom Apr 7, 2019
Merged
Creating test user service; Add fraud prevention headers#14s-patompong merged 10 commits intos-patompong:masterfrom
s-patompong merged 10 commits intos-patompong:masterfrom
Conversation
Owner
|
Sorry I was busy and just see this today. I'll need to have a look at the code and will merge if everything is ok. |
Contributor
Author
|
No problem. I will use this PR in production after release which will happen this Sunday, so it has to be OK. |
Owner
|
I did change $request_headers to $requestHeaders in Environment class. This is for consistency of the project. I'll find a way to add the rule into StypeCI. |
Owner
|
PR is merged to master and released as v1.2.0 (https://github.com/s-patompong/hmrc-api-php/releases/tag/v1.2.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
Fixes:
Usage example: