XML values are always required#125
Merged
sabomichal merged 2 commits intosabomichal:masterfrom Apr 12, 2024
Merged
Conversation
Since a primitive will always be present with some value it does not really make sense to wrap them in an optional. fix issue sabomichal#107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential fix for the issue described in #124 together with a unit test to prevent any future regressions.
fixes #124
Since I just also ran into the issue with primitive fields I've added a potential fix and unit test for that to this PR as well. I decided to not make two separate PRs to prevent a potential merge conflict as both changes affect the same areas of the codebase.
fixes #107